Skip to content

Follow up on the removal of update and merge in Accumulator #1598

Closed

Description

@jimexist

I think it would be a good idea as a follow on PR to update these implementations to avoid the use of ScalarValue.

I'll try find some time this week to do it (I need some coding time :) -- lots of reviewing so far)

Originally posted by @alamb in #1582 (comment)

Activity

  1. alamb commented on Jan 21, 2022

    @alamb
    Contributor

    Basically the idea here would be to rewrite the implementations that use ScalarValue to directly use the appriate arrow compute kernels: https://docs.rs/arrow/7.0.0/arrow/compute/index.html

  2. Weijun-H commented on Apr 19, 2023

    @Weijun-H
    Member

    This issue can be closed, because all parts are refactored.

  3. alamb commented on Apr 21, 2023

    @alamb
    Contributor

    Thank you @Weijun-H

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions