-
Notifications
You must be signed in to change notification settings - Fork 2k
Closed
Labels
good first issueGood for newcomersGood for newcomers
Description
In #15178, we're switching hard-coded constants in tests to insta.
This issue targets updating physical plan tests (datafusion/physical-plan).
Examples of tests that need to be switched to insta
datafusion/datafusion/physical-plan/src/aggregates/topk/priority_map.rs
Lines 133 to 137 in 0e77fb2
+----------+--------------+ | trace_id | timestamp_ms | +----------+--------------+ | 1 | 1 | +----------+--------------+ datafusion/datafusion/physical-plan/src/unnest.rs
Lines 1149 to 1159 in 0e77fb2
"+---------------------------------+---------------------------------+---------------------------------+", "| col1_unnest_placeholder_depth_1 | col1_unnest_placeholder_depth_2 | col2_unnest_placeholder_depth_1 |", "+---------------------------------+---------------------------------+---------------------------------+", "| [1, 2, 3] | 1 | a |", "| | 2 | b |", "| [4, 5] | 3 | |", "| [1, 2, 3] | | a |", "| | | b |", "| [4, 5] | | |", "| [1, 2, 3] | 4 | a |", "| | 5 | b |", datafusion/datafusion/physical-plan/src/aggregates/topk/heap.rs
Lines 536 to 539 in 0e77fb2
val=3 idx=0, bucket=3 ├── val=1 idx=1, bucket=1 └── val=2 idx=2, bucket=2 "#;
Check the original issue for tips on how to do the switch and examples of completed PRs.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers