Repository navigation
Convert Option<Vec<sort expression>> to Vec<sort expression> #12195
Description
Consider AggregateFunction.order_by field -- it is Option<Vec< /*sort expr*/ >>
None means "no sorting" but this can be modeled as Some( vec![] ).
Empty collection perfectly describes lack of sorting, so no need to wrap if with optional value.
Remove Option and keep just Vec.
This can be applied to
AggregateFunction.order_byExprFuncBuilder.order_by- ...
based on #12178 (comment) cc @crepererum
Activity
findepi commentedon Aug 27, 2024
take
findepi commentedon Aug 27, 2024
plan to work on this after #12193, as the two will conflict.
[-]Make `AggregateFunction.order_by` non-Option field[/-][+]Convert `Option<Vec<sort expression>>` to `Vec<sort expression>`[/+]ViggoC commentedon Jun 29, 2025
Hi @findepi, can I take it if you do not work on it anymore?
findepi commentedon Jun 29, 2025
sure, go for it!
Merge branch 'main' into apachegh-12195