Skip to content

Replace assertions with error macros #10232

Closed

Description

@comphead

There are some places in Datafusion doing assertions which leads the application to crash. Its better to replace assertions with error wherever possible

Example: assert_eq! here to keep it consistent with other implementations of GroupsAccumulator. Eg. see here among others:
https://github.com/apache/datafusion/blob/main/datafusion/physical-expr/src/aggregate/groups_accumulator/prim_op.rs?plain=1#L93

Originally posted by @lkt in #10149 (comment)

Activity

  1. Jefffrey commented on Nov 27, 2025

    @Jefffrey
    Contributor

    Is this resolved by #18613 now? Thoughts @2010YOUY01?

  2. 2010YOUY01 commented on Nov 27, 2025

    @2010YOUY01
    Member

    Is this resolved by #18613 now? Thoughts @2010YOUY01?

    I think so, let's close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions