Skip to content

Commit f29364d

Browse files
adriangbclaude
andcommitted
fix: typos lint and force_hash_collisions snapshot
- Rephrase a doc comment in row_filter.rs to avoid "mis-" hyphenation that triggers the typos spell-check in CI. - Update the force_hash_collisions variant of test_hashjoin_dynamic_filter_pushdown_partitioned to expect the Optional(DynamicFilter [...]) wrapper introduced in this branch. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
1 parent c7b55cc commit f29364d

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎datafusion/core/tests/physical_optimizer/filter_pushdown.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1101,7 +1101,7 @@ async fn test_hashjoin_dynamic_filter_pushdown_partitioned() {
11011101
- RepartitionExec: partitioning=Hash([a@0, b@1], 12), input_partitions=1
11021102
- DataSourceExec: file_groups={1 group: [[test.parquet]]}, projection=[a, b, c], file_type=test, pushdown_supported=true
11031103
- RepartitionExec: partitioning=Hash([a@0, b@1], 12), input_partitions=1
1104-
- DataSourceExec: file_groups={1 group: [[test.parquet]]}, projection=[a, b, e], file_type=test, pushdown_supported=true, predicate=DynamicFilter [ a@0 >= aa AND a@0 <= ab AND b@1 >= ba AND b@1 <= bb AND struct(a@0, b@1) IN (SET) ([{c0:aa,c1:ba}, {c0:ab,c1:bb}]) ]
1104+
- DataSourceExec: file_groups={1 group: [[test.parquet]]}, projection=[a, b, e], file_type=test, pushdown_supported=true, predicate=Optional(DynamicFilter [ a@0 >= aa AND a@0 <= ab AND b@1 >= ba AND b@1 <= bb AND struct(a@0, b@1) IN (SET) ([{c0:aa,c1:ba}, {c0:ab,c1:bb}]) ])
11051105
"
11061106
);
11071107

‎datafusion/datasource-parquet/src/row_filter.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ pub(crate) struct DatafusionArrowPredicate {
136136
/// post-scan path reports in `apply_post_scan_filters_with_stats`
137137
/// (see `opener.rs::post_scan_other_bytes_per_row`); if the two
138138
/// paths disagreed, the tracker would rank row-filter and post-scan
139-
/// candidates on incomparable axes and mis-promote or mis-demote.
139+
/// candidates on incomparable axes and wrongly promote or demote them.
140140
other_projected_bytes_per_row: f64,
141141
/// Mid-stream "drop" flag, shared with the
142142
/// [`crate::selectivity::SelectivityTracker`]. The tracker flips this

0 commit comments

Comments
 (0)