@@ -505,7 +505,7 @@ impl ScalarUDFImpl for GetFieldFunc {
505505 // 1. The base (first arg) is a column or already placeable at leaves
506506 // 2. All field keys (remaining args) are literals
507507 if args. is_empty ( ) {
508- return ExpressionPlacement :: MoveTowardsRootNodes ;
508+ return ExpressionPlacement :: KeepInPlace ;
509509 }
510510
511511 let base_placement = args[ 0 ] ;
@@ -522,7 +522,7 @@ impl ScalarUDFImpl for GetFieldFunc {
522522 if base_is_pushable && all_keys_are_literals {
523523 ExpressionPlacement :: MoveTowardsLeafNodes
524524 } else {
525- ExpressionPlacement :: MoveTowardsRootNodes
525+ ExpressionPlacement :: KeepInPlace
526526 }
527527 }
528528}
@@ -608,21 +608,15 @@ mod tests {
608608
609609 // get_field(col, other_col) -> NOT leaf-pushable (dynamic per-row lookup)
610610 let args = vec ! [ ExpressionPlacement :: Column , ExpressionPlacement :: Column ] ;
611- assert_eq ! (
612- func. placement( & args) ,
613- ExpressionPlacement :: MoveTowardsRootNodes
614- ) ;
611+ assert_eq ! ( func. placement( & args) , ExpressionPlacement :: KeepInPlace ) ;
615612
616613 // get_field(col, 'a', other_col) -> NOT leaf-pushable (dynamic nested lookup)
617614 let args = vec ! [
618615 ExpressionPlacement :: Column ,
619616 ExpressionPlacement :: Literal ,
620617 ExpressionPlacement :: Column ,
621618 ] ;
622- assert_eq ! (
623- func. placement( & args) ,
624- ExpressionPlacement :: MoveTowardsRootNodes
625- ) ;
619+ assert_eq ! ( func. placement( & args) , ExpressionPlacement :: KeepInPlace ) ;
626620 }
627621
628622 #[ test]
@@ -631,34 +625,25 @@ mod tests {
631625
632626 // get_field(root_expr, 'literal') -> NOT leaf-pushable
633627 let args = vec ! [
634- ExpressionPlacement :: MoveTowardsRootNodes ,
628+ ExpressionPlacement :: KeepInPlace ,
635629 ExpressionPlacement :: Literal ,
636630 ] ;
637- assert_eq ! (
638- func. placement( & args) ,
639- ExpressionPlacement :: MoveTowardsRootNodes
640- ) ;
631+ assert_eq ! ( func. placement( & args) , ExpressionPlacement :: KeepInPlace ) ;
641632
642633 // get_field(col, root_expr) -> NOT leaf-pushable
643634 let args = vec ! [
644635 ExpressionPlacement :: Column ,
645- ExpressionPlacement :: MoveTowardsRootNodes ,
636+ ExpressionPlacement :: KeepInPlace ,
646637 ] ;
647- assert_eq ! (
648- func. placement( & args) ,
649- ExpressionPlacement :: MoveTowardsRootNodes
650- ) ;
638+ assert_eq ! ( func. placement( & args) , ExpressionPlacement :: KeepInPlace ) ;
651639 }
652640
653641 #[ test]
654642 fn test_placement_edge_cases ( ) {
655643 let func = GetFieldFunc :: new ( ) ;
656644
657645 // Empty args -> NOT leaf-pushable
658- assert_eq ! (
659- func. placement( & [ ] ) ,
660- ExpressionPlacement :: MoveTowardsRootNodes
661- ) ;
646+ assert_eq ! ( func. placement( & [ ] ) , ExpressionPlacement :: KeepInPlace ) ;
662647
663648 // Just base, no key -> MoveTowardsLeafNodes (not a valid call but should handle gracefully)
664649 let args = vec ! [ ExpressionPlacement :: Column ] ;
@@ -669,9 +654,6 @@ mod tests {
669654
670655 // Literal base with literal key -> NOT leaf-pushable (would be constant-folded)
671656 let args = vec ! [ ExpressionPlacement :: Literal , ExpressionPlacement :: Literal ] ;
672- assert_eq ! (
673- func. placement( & args) ,
674- ExpressionPlacement :: MoveTowardsRootNodes
675- ) ;
657+ assert_eq ! ( func. placement( & args) , ExpressionPlacement :: KeepInPlace ) ;
676658 }
677659}
0 commit comments