Repository navigation
Commit e93950b
docs: state what the tests hold down, not when it was found
Three comments described this change's own history rather than the code:
"the nested shape from review", "both left the inner SortExec a full sort
before this PR", and "reachable only once applying a fetch stops ending
the walk, which is the first commit in this PR". After a squash merge
none of those have a referent, and a reader of the test has no way to
resolve them.
Each now states the same thing as a property of the rule: what the shape
is, what the plan looks like if the stale phase survives, and what has to
be true of the traversal for the shape to be reachable at all.
Comments only -- no test, plan or snapshot changes.
Co-Authored-By: Claude Opus 5 <[email protected]>1 parent 8559e7c commit e93950b
2 files changed
Lines changed: 8 additions & 8 deletions
File tree
- datafusion
- physical-optimizer/src
- sqllogictest/test_files
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
445 | 445 | | |
446 | 446 | | |
447 | 447 | | |
448 | | - | |
449 | | - | |
450 | | - | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
451 | 451 | | |
452 | 452 | | |
453 | 453 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1019 | 1019 | | |
1020 | 1020 | | |
1021 | 1021 | | |
1022 | | - | |
1023 | | - | |
| 1022 | + | |
| 1023 | + | |
1024 | 1024 | | |
1025 | 1025 | | |
1026 | 1026 | | |
| |||
1186 | 1186 | | |
1187 | 1187 | | |
1188 | 1188 | | |
1189 | | - | |
1190 | | - | |
1191 | | - | |
| 1189 | + | |
| 1190 | + | |
| 1191 | + | |
1192 | 1192 | | |
1193 | 1193 | | |
1194 | 1194 | | |
| |||
0 commit comments