You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit e7304ee
Browse filesBrowse the repository at this point in the historyBrowse files
fix: do not derive ordering for arithmetic that can overflow (#23910)
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes#123` indicates that this PR will close issue #123.
-->
- Closes#23902.
## Rationale for this change
Please check the issue for details but the main idea is that `a + b`
over two
sorted columns is not guaranteed to be sorted.
## What changes are included in this PR?
Ordering is discarded when it overflows or wraps
## Are these changes tested?
Yes, adjusted existing tests and added a regression test in `order.slt`.
## Are there any user-facing changes?
no api changes
"Error in test case requirement:{ordering:?}, expected: {expected:?}, eq_properties: {eq_properties}, projected_eq: {projected_eq}, projection_mapping: {projection_mapping:?}"
181
181
);
182
-
// Check whether ordering_satisfy API result and
183
-
// experimental result matches.
184
-
assert_eq!(
185
-
projected_eq.ordering_satisfy(ordering)?,
186
-
expected,
187
-
"{err_msg}"
182
+
// Same reasoning as in `ordering.rs`: only keys from
183
+
// the first `+`/`-` source onwards are inconclusive,
0 commit comments