Repository navigation
Commit dc92bb8
authored
## Which issue does this PR close?
N/A — a trivial build-warning fix, no tracking issue.
## Rationale for this change
Building `datafusion-physical-expr` without the `proto` feature emits an
`unused import` warning:
```
warning: unused import: `internal_datafusion_err`
--> datafusion/physical-expr/src/expressions/dynamic_filters/mod.rs:26
```
`internal_datafusion_err` is only referenced inside
`impl DynamicFilterPhysicalExpr { fn try_from_proto(..) }`, which is
itself gated
behind `#[cfg(feature = "proto")]`. The import was unconditional, so it
became
dead whenever `proto` is disabled.
## What changes are included in this PR?
Move the `internal_datafusion_err` import behind `#[cfg(feature =
"proto")]` so it
is compiled only when its sole use site is, matching the existing gate
on the
`try_from_proto` impl block.
## Are these changes tested?
No new tests — this is a compile-time-only change. It is exercised by
existing CI,
which builds the crate both with and without the `proto` feature; the
warning
(promoted to an error under `-D warnings`) no longer fires.
## Are there any user-facing changes?
No.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Signed-off-by: Jiawei Zhao <[email protected]>
1 parent 48a5e21 commit dc92bb8
1 file changed
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
| 26 | + | |
25 | 27 | | |
26 | | - | |
| 28 | + | |
27 | 29 | | |
28 | 30 | | |
| 31 | + | |
29 | 32 | | |
30 | 33 | | |
31 | 34 | | |
| |||
0 commit comments