Repository navigation
Commit dbdfcee
committed
Address review: infallible RowFilterContext::build_row_filter, lazy initial filter, doc name
- RowFilterContext::try_new only constructs a context when the prebuilt list
is non-empty, so build_row_filter now returns RowFilter directly and the
unreachable empty arm (and PrebuiltRowFilterCandidateList::is_empty) is gone.
- The opener no longer builds the initial RowFilter eagerly just to discard it
when the first row group is fully matched; it is built lazily in the
non-fully-matched branch only.
- Fix doc reference: RowFilterContext::build -> build_row_filter.1 parent 5a173c9 commit dbdfcee
3 files changed
Lines changed: 16 additions & 32 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1552 | 1552 | | |
1553 | 1553 | | |
1554 | 1554 | | |
1555 | | - | |
1556 | | - | |
1557 | | - | |
1558 | 1555 | | |
1559 | 1556 | | |
1560 | 1557 | | |
1561 | 1558 | | |
1562 | 1559 | | |
1563 | | - | |
| 1560 | + | |
1564 | 1561 | | |
1565 | 1562 | | |
1566 | 1563 | | |
1567 | 1564 | | |
1568 | | - | |
| 1565 | + | |
| 1566 | + | |
| 1567 | + | |
1569 | 1568 | | |
1570 | 1569 | | |
1571 | 1570 | | |
1572 | 1571 | | |
1573 | 1572 | | |
1574 | | - | |
| 1573 | + | |
1575 | 1574 | | |
1576 | 1575 | | |
1577 | 1576 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
340 | 340 | | |
341 | 341 | | |
342 | 342 | | |
343 | | - | |
344 | | - | |
345 | | - | |
346 | | - | |
347 | 343 | | |
348 | 344 | | |
349 | 345 | | |
| |||
397 | 393 | | |
398 | 394 | | |
399 | 395 | | |
400 | | - | |
401 | | - | |
402 | | - | |
403 | | - | |
404 | | - | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
405 | 401 | | |
406 | 402 | | |
407 | 403 | | |
408 | | - | |
| 404 | + | |
409 | 405 | | |
410 | 406 | | |
411 | 407 | | |
| |||
667 | 663 | | |
668 | 664 | | |
669 | 665 | | |
670 | | - | |
671 | | - | |
672 | | - | |
673 | | - | |
674 | | - | |
675 | | - | |
676 | | - | |
677 | | - | |
678 | | - | |
679 | | - | |
680 | | - | |
681 | | - | |
682 | | - | |
683 | | - | |
684 | | - | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
685 | 669 | | |
| 670 | + | |
686 | 671 | | |
687 | 672 | | |
688 | 673 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
428 | 428 | | |
429 | 429 | | |
430 | 430 | | |
431 | | - | |
| 431 | + | |
432 | 432 | | |
433 | 433 | | |
434 | 434 | | |
| |||
0 commit comments