You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit d336e0e
Browse filesBrowse the repository at this point in the historyBrowse files
Uses `decimal_coercion` directly at the call site and drops
`pmod_computation_type`: only a decimal pair can reach that branch, since
`Numeric(2)` already gives every other combination a common type.
Returns a null scalar rather than building a null array for the null
short-circuit.
Removes comments that were wrong or unnecessary: a doc paragraph referencing
`SparkPmod::coerce_types`, which this PR deletes; a claim that the computation
type is wide enough by construction alongside a justification for overflow
handling; and a pointer to an ANSI assertion "further down" that sits above it.
Drops three sqllogictest cases that were duplicated in two places, and the
value assertions that only restated the type assertions beside them.
// `Coercible` matches a null argument and passes it through
306
-
// uncoerced (#19458), so an untyped NULL reaches here rather than
307
-
// being folded by `Numeric(2)`. `mod` answers `Float64` for two
308
-
// untyped nulls and the other side's type when only one is null;
309
-
// `pmod` did too, so that behaviour is kept explicitly here.
295
+
// Need to handle nulls explicitly, see: https://github.com/apache/datafusion/issues/19458
0 commit comments