Repository navigation
Commit cc17378
committed
Clear ORDER BY for order-insensitive aggregates in AggregateExprBuilder
Instead of passing empty ordering fields from state_fields(), drop the
ORDER BY in AggregateExprBuilder::build() when the function is
order-insensitive. The ordering fields are then empty from the start, so
the aggregate carries no ordering state that later code has to ignore.
Also cover the ungrouped case. It fails the same way once the aggregation
runs in Partial and Final modes; the filter makes the single-partition
`sales_global` input multi-partition so the test reaches that path.1 parent 90cff05 commit cc17378
2 files changed
Lines changed: 24 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
264 | 264 | | |
265 | 265 | | |
266 | 266 | | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
267 | 276 | | |
268 | 277 | | |
269 | 278 | | |
| |||
759 | 768 | | |
760 | 769 | | |
761 | 770 | | |
762 | | - | |
763 | | - | |
764 | | - | |
765 | | - | |
766 | | - | |
767 | | - | |
768 | | - | |
769 | 771 | | |
770 | 772 | | |
771 | 773 | | |
772 | 774 | | |
773 | | - | |
| 775 | + | |
774 | 776 | | |
775 | 777 | | |
776 | 778 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3076 | 3076 | | |
3077 | 3077 | | |
3078 | 3078 | | |
3079 | | - | |
3080 | | - | |
| 3079 | + | |
| 3080 | + | |
3081 | 3081 | | |
3082 | 3082 | | |
3083 | 3083 | | |
| |||
3090 | 3090 | | |
3091 | 3091 | | |
3092 | 3092 | | |
| 3093 | + | |
| 3094 | + | |
| 3095 | + | |
| 3096 | + | |
| 3097 | + | |
| 3098 | + | |
| 3099 | + | |
| 3100 | + | |
| 3101 | + | |
| 3102 | + | |
| 3103 | + | |
| 3104 | + | |
3093 | 3105 | | |
3094 | 3106 | | |
3095 | 3107 | | |
| |||
0 commit comments