@@ -1182,6 +1182,18 @@ SELECT log(x) FROM (VALUES (0.0::float8)) AS t(x)
11821182query error DataFusion error: Arrow error: Compute error: cannot take logarithm of zero
11831183SELECT log(0::decimal(10, 2))
11841184
1185+ # log(0, 0) must not simplify to 1
1186+ query error DataFusion error: Arrow error: Compute error: cannot take logarithm of zero
1187+ SELECT log(0.0::float8, 0.0::float8)
1188+
1189+ # log(a, power(a, b)) must not rewrite to b when the power result is zero
1190+ query error DataFusion error: Arrow error: Compute error: cannot take logarithm of zero
1191+ SELECT log(0.0::float8, power(0.0::float8, 1.0::float8))
1192+
1193+ # underflow of a positive base still yields a zero power result
1194+ query error DataFusion error: Arrow error: Compute error: cannot take logarithm of zero
1195+ SELECT log(2.0::float8, power(2.0::float8, -2000.0::float8))
1196+
11851197# factorial negative (PostgreSQL-compatible domain error)
11861198query error DataFusion error: Execution error: factorial of a negative number is undefined
11871199select factorial(-1);
@@ -1233,7 +1245,9 @@ physical_plan
1233124501)ProjectionExec: expr=[log(column1@0, 1) as l1, log(column1@0, column1@0) as la, power(column1@0, 0) as p0, power(column1@0, log(column1@0, column2@1)) as pl]
1234124602)--DataSourceExec: partitions=1, partition_sizes=[1]
12351247
1236- # Non-nullable bases still use the existing simplifications
1248+ # Non-nullable bases still use simplifications that cannot skip domain checks.
1249+ # log(a, 1) and power(...) are unchanged. log(a, a) is not rewritten because
1250+ # a column is not a known-positive literal.
12371251query TT
12381252EXPLAIN SELECT
12391253 log(a, 1) AS l1,
@@ -1243,14 +1257,36 @@ EXPLAIN SELECT
12431257FROM (VALUES (2.0::double, 3.0::double)) AS t(a, b);
12441258----
12451259logical_plan
1246- 01)Projection: Float64(0) AS l1, Float64(1 ) AS la, Float64(1) AS p0, t.b AS pl
1260+ 01)Projection: Float64(0) AS l1, log(t.a, t.a ) AS la, Float64(1) AS p0, t.b AS pl
1247126102)--SubqueryAlias: t
1248- 03)----Projection: column2 AS b
1262+ 03)----Projection: column1 AS a, column2 AS b
1249126304)------Values: (Float64(2), Float64(3))
12501264physical_plan
1251- 01)ProjectionExec: expr=[0 as l1, 1 as la, 1 as p0, column2@1 as pl]
1265+ 01)ProjectionExec: expr=[0 as l1, log(column1@0, column1@0) as la, 1 as p0, column2@1 as pl]
1252126602)--DataSourceExec: partitions=1, partition_sizes=[1]
12531267
1268+ # Known-positive literals still use log(a, a) => 1
1269+ query TT
1270+ EXPLAIN SELECT log(2.0::float8, 2.0::float8);
1271+ ----
1272+ logical_plan
1273+ 01)Projection: Float64(1) AS log(Float64(2),Float64(2))
1274+ 02)--EmptyRelation: rows=1
1275+ physical_plan
1276+ 01)ProjectionExec: expr=[1 as log(Float64(2),Float64(2))]
1277+ 02)--PlaceholderRowExec
1278+
1279+ # Known-positive power result still uses log(a, power(a, b)) => b
1280+ query TT
1281+ EXPLAIN SELECT log(2.0::float8, power(2.0::float8, 3.0::float8));
1282+ ----
1283+ logical_plan
1284+ 01)Projection: Float64(3) AS log(Float64(2),power(Float64(2),Float64(3)))
1285+ 02)--EmptyRelation: rows=1
1286+ physical_plan
1287+ 01)ProjectionExec: expr=[3 as log(Float64(2),power(Float64(2),Float64(3)))]
1288+ 02)--PlaceholderRowExec
1289+
12541290# Float 16/32/64 for log
12551291query RT
12561292SELECT log(2.5, arrow_cast(10.9, 'Float16')), arrow_typeof(log(2.5, arrow_cast(10.9, 'Float16')));
0 commit comments