Repository navigation
Commit bbb552f
[Parquet] Skip bloom filter predicate evaluation when no bloom filters are loaded (#24101)
## Which issue does this PR close?
- Closes #24107
## Rationale for this change
Bloom filter pruning codepath evaluates pruning predicates even when no
bloom filters are defined for the row group.
For wide / expensive predicates, this can add visible latency.
This PR suggests shunting the evaluation of the predicate altogether
when a row group provably doesn't contain bloom filters.
## What changes are included in this PR?
Short-circuits the pruning predicate evaluation in bloom filter pruning
codepath when there are no bloom filters.
## Are these changes tested?
Yes, but the assertions are weak and cannot differentiate between a
skipped pruning predicate (no bloom filter case) vs a pruning predicate
that was evaluated and matches the row group.
I suppose we could build a test with an expensive predicate, and rely on
the timer, but I find time-based tests to be generally weak/flaky. Let
me know if you prefer this solution / if you see a better approach.
## Are there any user-facing changes?
None
---------
Co-authored-by: Andrew Lamb <[email protected]>1 parent 766ca58 commit bbb552f
2 files changed
Lines changed: 49 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
64 | 69 | | |
65 | 70 | | |
66 | 71 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
434 | 434 | | |
435 | 435 | | |
436 | 436 | | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
437 | 446 | | |
438 | 447 | | |
439 | 448 | | |
| |||
544 | 553 | | |
545 | 554 | | |
546 | 555 | | |
| 556 | + | |
547 | 557 | | |
548 | 558 | | |
549 | 559 | | |
| |||
1382 | 1392 | | |
1383 | 1393 | | |
1384 | 1394 | | |
| 1395 | + | |
| 1396 | + | |
| 1397 | + | |
| 1398 | + | |
| 1399 | + | |
| 1400 | + | |
| 1401 | + | |
| 1402 | + | |
| 1403 | + | |
| 1404 | + | |
| 1405 | + | |
| 1406 | + | |
| 1407 | + | |
| 1408 | + | |
| 1409 | + | |
| 1410 | + | |
| 1411 | + | |
| 1412 | + | |
| 1413 | + | |
| 1414 | + | |
| 1415 | + | |
| 1416 | + | |
| 1417 | + | |
| 1418 | + | |
| 1419 | + | |
| 1420 | + | |
| 1421 | + | |
| 1422 | + | |
| 1423 | + | |
| 1424 | + | |
| 1425 | + | |
| 1426 | + | |
| 1427 | + | |
| 1428 | + | |
1385 | 1429 | | |
1386 | 1430 | | |
1387 | 1431 | | |
| |||
0 commit comments