Skip to content

Commit b74393a

Browse files
authored
fix: Skip flaky test in explain_analyze.slt (#21866)
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #21850 ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> The failing test can't be easily tested now, see the comment for the reason. So I suggest we suppress it now. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
1 parent 65f337d commit b74393a

1 file changed

Lines changed: 10 additions & 4 deletions

File tree

‎datafusion/sqllogictest/test_files/explain_analyze.slt‎

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -100,10 +100,16 @@ CREATE EXTERNAL TABLE skew_parquet
100100
STORED AS PARQUET
101101
LOCATION 'test_files/scratch/explain_analyze/output_rows_skew';
102102

103-
query TT
104-
EXPLAIN ANALYZE SELECT * FROM skew_parquet;
105-
----
106-
Plan with Metrics DataSourceExec: <slt:ignore>output_rows_skew=84.31%<slt:ignore>
103+
# Skipped:
104+
# After https://github.com/apache/datafusion/pull/21351, the Parquet scan order
105+
# is no longer deterministic, so this metric cannot be reliably tested.
106+
# Coverage can be restored by implementing this metric in other executors,
107+
# such as the memory table.
108+
#
109+
# query TT
110+
# EXPLAIN ANALYZE SELECT * FROM skew_parquet;
111+
# ----
112+
# Plan with Metrics DataSourceExec: <slt:ignore>output_rows_skew=84.31%<slt:ignore>
107113

108114
# All partition's output_rows: [0]
109115
statement ok

0 commit comments

Comments
 (0)