Repository navigation
Commit b645de0
authored
Keep ClickBench SQL in sync across runners (#25773)
## Which issue does this PR close?
- Part of #25031
## Rationale for this change
The extended Q6 benchmark uses different SQL from the other ClickBench
runners, while Q15 and Q16 are absent from the SQL-benchmark suite and
SQL logic test. These copies can drift again when a query is edited in
only one place.
## What changes are included in this PR?
- Remove the URL cast from the extended Q6 benchmark query.
- Add extended Q15 and Q16 SQL benchmarks and corresponding SQL logic
test entries.
- Add a parity test for standard and extended ClickBench. It checks that
each benchmark query appears in its SQL logic test and that benchmark
and legacy query files have matching IDs and normalized SQL.
- Update both SQL logic test headers to identify the mirrored query
locations.
## Are these changes tested?
The patch adds `clickbench_parity.rs` and six unit tests covering SQL
logic test parsing and SQL normalization. It also adds Q15/Q16 SQL logic
test entries with expected value `0`.
The diff does not show test execution, generation of those expected
values, or the requested Q6 comparisons in single and partitioned
configurations.
## Are there any user-facing changes?
The extended Q6 SQL benchmark now runs without the URL cast. Q15 and Q16
are added to the extended SQL-benchmark suite. The diff does not
establish whether removing the cast changes Q6 results. No public API
change is shown.
## LLM-generated code disclosure
This PR includes LLM-generated code and comments. All LLM-generated
content has been manually reviewed.1 parent db425eb commit b645de0
6 files changed
Lines changed: 517 additions & 3 deletions
File tree
- benchmarks
- sql_benchmarks/clickbench_extended/benchmarks
- tests
- datafusion/sqllogictest/test_files
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
0 commit comments