Repository navigation
Commit b3f0806
review: reject nested-list ORDER BY keys in free RANGE frames
`check_free_range_order_by_types` only runs when the first ORDER BY key
has no offset target (Duration, Interval), and it accepted any later key
that `extract_window_frame_target_type` accepts. That let `ORDER BY d, l`
with `l: List<Struct>` pass planning and fail at execution with
"Uncomparable values", whereas on main the Duration key already stopped
it in the planner. Reject lists of nested elements in that check so the
query keeps failing at planning; the direct `List<Struct>` cases stay as
they were on main, for the comparator follow-up.
Co-Authored-By: Claude Opus 5 <[email protected]>1 parent 727c003 commit b3f0806
2 files changed
Lines changed: 34 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1150 | 1150 | | |
1151 | 1151 | | |
1152 | 1152 | | |
1153 | | - | |
| 1153 | + | |
| 1154 | + | |
| 1155 | + | |
| 1156 | + | |
| 1157 | + | |
| 1158 | + | |
| 1159 | + | |
| 1160 | + | |
| 1161 | + | |
| 1162 | + | |
| 1163 | + | |
| 1164 | + | |
| 1165 | + | |
| 1166 | + | |
| 1167 | + | |
| 1168 | + | |
| 1169 | + | |
| 1170 | + | |
| 1171 | + | |
| 1172 | + | |
1154 | 1173 | | |
1155 | 1174 | | |
1156 | 1175 | | |
1157 | 1176 | | |
1158 | 1177 | | |
1159 | 1178 | | |
1160 | | - | |
1161 | | - | |
1162 | | - | |
| 1179 | + | |
| 1180 | + | |
| 1181 | + | |
1163 | 1182 | | |
1164 | 1183 | | |
1165 | 1184 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7155 | 7155 | | |
7156 | 7156 | | |
7157 | 7157 | | |
7158 | | - | |
7159 | | - | |
7160 | | - | |
| 7158 | + | |
| 7159 | + | |
| 7160 | + | |
| 7161 | + | |
| 7162 | + | |
| 7163 | + | |
| 7164 | + | |
| 7165 | + | |
| 7166 | + | |
| 7167 | + | |
| 7168 | + | |
7161 | 7169 | | |
7162 | 7170 | | |
7163 | 7171 | | |
| |||
0 commit comments