You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit ad7d6ea
Browse filesBrowse the repository at this point in the historyBrowse files
fix: Handle decimal columns consistently in SLT tests (#23161)
## Which issue does this PR close?
- Closes#23160.
## Rationale for this change
As described in the issue, different width decimals are currently
handled differently, going through inconsistent display path and not
presenting the full precision.
## What changes are included in this PR?
1. Unifies all handling and formatting for the four decimal variants,
which are now all supported. Also includes full display of decimal
values up to the specified precision, which should be deterministic.
2. I've also reran the all tests with `--complete`, which makes a few
random changes around empty whitespaces which I think is good to run
periodically (I keep doing that locally in unrelated changes and having
to `git restore` a bunch of files). Would it make sense to maybe add
this check to CI and verify it leaves the worktree clean?
## Are these changes tested?
Ran all tests locally
## Are there any user-facing changes?
Users of `datafusion-sqllogictest` will get different results if they
depend on the existing behavior.
---------
Signed-off-by: Adam Gutglick <[email protected]>
0 commit comments