Repository navigation
Commit a5c809f
chore: Fix duplicated word typos in comments and docs (#25048)
## Which issue does this PR close?
No issue. This follows the precedent of prior comment-typo cleanups,
which were merged without a linked issue:
- #23662 `chore: Fix duplicated word typos in comments` (10 files,
+14/-14)
- #21495 ``chore: Fix `typo` problems`` (10 files, +14/-14)
- #22625 `chore: Fix typos in comments` (2 files, +2/-2)
- #22524 `chore: fix two comment typos` (2 files, +4/-4)
- #20157 `chore: Fix typos in comments` (1 file, +2/-2)
## Rationale for this change
Several comments and doc comments contain accidentally doubled words —
`the sort sort options`, `can not not vary`, `types types from`. Four of
them are rustdoc on public methods, so they render on docs.rs.
These survive automated checking because the CI typo checker
(`ci/scripts/typos_check.sh`, the `typos` crate) matches misspelled
*words* and does not detect a correctly spelled word repeated twice in a
row. Searching the tree for `\b(\w+)\s+\1\b` restricted to comment and
prose lines finds the cases below; the remaining matches are ASCII-art
plan diagrams and pasted `parquet-tools` output, which are left alone.
## What changes are included in this PR?
Removes 7 doubled words across 6 Rust files and 1 documentation file (13
lines). Comment and prose text only — no code changes.
| File | Fix |
| --- | --- |
| `datafusion/physical-expr-common/src/sort_expr.rs` (x4) | `Set the
sort sort options` on the public `asc` / `desc` / `nulls_first` /
`nulls_last` builders |
| `datafusion/core/src/datasource/file_format/options.rs` (x4) | `can
not not vary from statement to statement` on the CSV / Parquet / Arrow /
Avro read options |
| `datafusion/expr/src/window_frame.rs` | `equivalent values for all all
terms` |
| `datafusion/expr/src/logical_plan/plan.rs` | `properly infer types
types from literal values` |
| `datafusion/physical-plan/src/repartition/distributor_channels.rs` |
`so we we can safely assume` |
| `datafusion-examples/examples/query_planning/expr_api.rs` | `The same
same expression` |
| `docs/source/contributor-guide/testing.md` | `you can run them them
locally` |
## What is the testing strategy for this PR?
No new tests. The change is confined to comments and prose, so there is
no behaviour to cover.
Checks run locally on Linux x86_64 with the pinned 1.97.0 toolchain:
- `cargo fmt --all --check` — pass
- `cargo clippy --all-targets --all-features -- -D warnings` — pass, no
warnings (full workspace, 22m)
- `./ci/scripts/doc_prettier_check.sh` — pass
- `cargo test --doc -p datafusion-physical-expr-common -p
datafusion-expr -p datafusion` — pass, 254 tests (186 + 60 + 8), 0
failed
I did not run the full extended test suite. No edited comment contains a
doctest code fence, and the workspace compiles cleanly under
`--all-features`, so the change cannot affect compiled or tested
behaviour.
## Are there any user-facing changes?
No API or behaviour changes. The rendered rustdoc for four public
`PhysicalSortExpr` builder methods and for the four `*ReadOptions`
structs is corrected.
---
## AI disclosure
This contribution was AI-assisted. Claude Code (Claude Opus 5) performed
the tree-wide doubled-word search, made the 13 line edits, and ran every
check listed above on Linux x86_64 with the pinned 1.97.0 toolchain. The
contributor reviewed the diff and the check output before this PR was
opened; the check commands themselves were executed by the AI and were
not independently re-run by hand.
The two `datafusion/core/src/lib.rs` doctests initially failed for a
missing `parquet-testing` submodule (`PARQUET_TEST_DATA` undefined)
rather than for any change in this PR; they pass once the submodule is
initialised. That file is not touched by this PR.
Co-authored-by: Claude Opus 5 (1M context) <[email protected]>1 parent b39cb4a commit a5c809f
7 files changed
Lines changed: 13 additions & 13 deletions
File tree
- datafusion-examples/examples/query_planning
- datafusion
- core/src/datasource/file_format
- expr/src
- logical_plan
- physical-expr-common/src
- physical-plan/src/repartition
- docs/source/contributor-guide
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
| 66 | + | |
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
| 53 | + | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| |||
246 | 246 | | |
247 | 247 | | |
248 | 248 | | |
249 | | - | |
| 249 | + | |
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
| |||
357 | 357 | | |
358 | 358 | | |
359 | 359 | | |
360 | | - | |
| 360 | + | |
361 | 361 | | |
362 | 362 | | |
363 | 363 | | |
| |||
403 | 403 | | |
404 | 404 | | |
405 | 405 | | |
406 | | - | |
| 406 | + | |
407 | 407 | | |
408 | 408 | | |
409 | 409 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1787 | 1787 | | |
1788 | 1788 | | |
1789 | 1789 | | |
1790 | | - | |
| 1790 | + | |
1791 | 1791 | | |
1792 | 1792 | | |
1793 | 1793 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
475 | 475 | | |
476 | 476 | | |
477 | 477 | | |
478 | | - | |
| 478 | + | |
479 | 479 | | |
480 | 480 | | |
481 | 481 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
107 | | - | |
| 107 | + | |
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | 112 | | |
113 | | - | |
| 113 | + | |
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
119 | | - | |
| 119 | + | |
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
125 | | - | |
| 125 | + | |
126 | 126 | | |
127 | 127 | | |
128 | 128 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
161 | 161 | | |
162 | 162 | | |
163 | 163 | | |
164 | | - | |
| 164 | + | |
165 | 165 | | |
166 | 166 | | |
167 | 167 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
164 | 164 | | |
165 | 165 | | |
166 | 166 | | |
167 | | - | |
| 167 | + | |
168 | 168 | | |
169 | 169 | | |
170 | 170 | | |
| |||
0 commit comments