Repository navigation
Commit 9f5714b
## Which issue does this PR close?
- Fixes #25705 on `branch-55`.
## Rationale for this change
This PR backports #25706 from @a10y to the `branch-55` line.
`quay.io/minio/minio` no longer allows anonymous pulls. `branch-55`
pulls that image for the `datafusion-cli` storage integration tests (it
moved there from Docker Hub in #25485), so the `cargo test
datafusion-cli (amd64)` job is expected to hit the same failure that
#25705 reported on `main`. The last `branch-55` CI run was on
2026-09-19, before the image became unavailable, so no run on this
branch has failed yet.
## What changes are included in this PR?
A clean `git cherry-pick -x` of e2ca7f3
with no conflicts. The patch is identical to the original (same `git
patch-id`).
- `datafusion-cli/tests/cli_integration.rs`: run the S3 tests against a
RustFS container (`docker.io/rustfs/rustfs:1.0.0`) instead of MinIO.
- `.github/workflows/rust.yml`: pre-pull the RustFS image instead of the
MinIO one.
- `datafusion-cli/Cargo.toml`: drop the `minio` feature of
`testcontainers-modules`.
- `datafusion-cli/CONTRIBUTING.md`: update the storage test docs.
## What is the testing strategy for this PR?
The existing `datafusion-cli` storage integration tests cover this
change, and CI runs them in the `cargo test datafusion-cli (amd64)` job.
On this branch, `datafusion-cli/tests/` and its snapshots match `main`
apart from one unrelated Spark test. `testcontainers` and
`testcontainers-modules` also resolve to the same versions as on `main`.
Locally, `cargo fmt --all -- --check`, `cargo clippy -p datafusion-cli
--all-targets --all-features -- -D warnings`, `taplo format --check` and
the prettier docs check pass. The Docker-based storage tests were not
run locally. CI runs them.
## Are there any user-facing changes?
No. The change only affects tests, CI and contributor docs.
Signed-off-by: Andrew Duffy <[email protected]>
Co-authored-by: Andrew Duffy <[email protected]>
1 parent 5c4db5a commit 9f5714b
4 files changed
Lines changed: 149 additions & 122 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
370 | 370 | | |
371 | 371 | | |
372 | 372 | | |
373 | | - | |
| 373 | + | |
374 | 374 | | |
375 | 375 | | |
376 | 376 | | |
377 | 377 | | |
378 | 378 | | |
379 | | - | |
380 | | - | |
381 | | - | |
382 | | - | |
383 | | - | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
384 | 383 | | |
385 | | - | |
| 384 | + | |
386 | 385 | | |
387 | | - | |
388 | | - | |
| 386 | + | |
| 387 | + | |
389 | 388 | | |
390 | 389 | | |
391 | 390 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
51 | | - | |
| 50 | + | |
| 51 | + | |
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | | - | |
| 80 | + | |
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
| |||
0 commit comments