Skip to content

Commit 9e0a08f

Browse files
gabotechsclaude
andauthored
Uncomment debug in Cargo.toml (#27261)
> [!IMPORTANT] > > **Fork CI setup:** For pull requests from a fork to `main`, enable workflows in your fork's **Actions** tab before you push. > See the [fork CI setup guide](https://datafusion.apache.org/contributor-guide/#pull-requests-from-forks). ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #. ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. Please explain the problem you are trying to solve in terms of the user-visible behavior, rather than the implementation. For example, "The code in `foo.rs` doesn't handle nulls" is a symptom of the implementation. "COUNT(DISTINCT) returns wrong results when the column contains nulls" is the user-visible problem. --> Just reverts an incidental change from #26155. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here, but it is sometimes worth providing a summary of the individual changes in this PR. --> Uncommenting one intentionally committed line ## What is the testing strategy for this PR? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code Briefly describe how this PR is tested, and point to the specific tests you added. For example: 'This new feature is covered by the `sqllogictest` cases added in `foo.slt`'. If this PR does not add tests, explain why. For example, if the change is already covered by existing tests, please mention it. You should also check the `codecov` bot reply on this PR to confirm the changed code is exercised. --> Just a Cargo.toml change ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please add the `api change` label. --> No --------- Co-authored-by: Claude Opus 5.5 <[email protected]>
1 parent c8265b6 commit 9e0a08f

1 file changed

Lines changed: 10 additions & 11 deletions

File tree

‎Cargo.toml‎

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -335,9 +335,10 @@ unused_qualifications = "deny"
335335
# Profiles available:
336336
# - dev: default debug build; fastest to compile, slowest to run. Carries line
337337
# tables only, so panics and backtraces still name a file and line but a
338-
# debugger cannot inspect variables; build with `CARGO_PROFILE_DEV_DEBUG=2`
339-
# when you need that. For everyday development; default for
340-
# "cargo [ build | test | run ]".
338+
# debugger cannot inspect variables; use the `dbg` profile when you need
339+
# that. For everyday development; default for "cargo [ build | test | run ]".
340+
# - dbg: like dev, but with full debug info for stepping through code and
341+
# inspecting variables in a debugger.
341342
# - release: fully optimized build; slowest to compile, fastest to run, smallest
342343
# binaries. For public releases; default for "cargo [ bench | install ]".
343344
# - release-nonlto: skips LTO, so it builds much faster while staying close to
@@ -351,15 +352,13 @@ unused_qualifications = "deny"
351352
# tasks.
352353
#
353354
# If you want to optimize compilation, the `compile_profile` benchmark can be useful.
354-
# See `benchmarks/README.md` for more details.
355-
# `dev` is the profile every `cargo build`/`cargo test` uses, so its debug info
356-
# is generated over and over. `line-tables-only` keeps file and line numbers --
357-
# so panics and `RUST_BACKTRACE` output stay useful -- while dropping the
358-
# variable-level DWARF that only an interactive debugger consumes. Build with
359-
# `CARGO_PROFILE_DEV_DEBUG=2 cargo build` when you need to step through code in a
360-
# debugger.
361355
[profile.dev]
362-
#debug = "line-tables-only"
356+
debug = "line-tables-only"
357+
358+
# Full debug info for interactive debugging ("debug" is a reserved profile name).
359+
[profile.dbg]
360+
inherits = "dev"
361+
debug = true
363362

364363
[profile.release]
365364
codegen-units = 1

0 commit comments

Comments
 (0)