Skip to content

Commit 9a3f30c

Browse files
committed
assert whole expr equals instead of only name in roudtrip test
1 parent 5688f3f commit 9a3f30c

1 file changed

Lines changed: 7 additions & 10 deletions

File tree

‎datafusion/proto/tests/cases/serialize.rs‎

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -294,13 +294,13 @@ fn test_expression_serialization_roundtrip() {
294294

295295
assert_eq!(serialize_name, deserialize_name);
296296
}
297-
}
298297

299-
/// Extracts the first part of a function name
300-
/// 'foo(bar)' -> 'foo'
301-
fn extract_function_name(expr: &Expr) -> String {
302-
let name = expr.schema_name().to_string();
303-
name.split('(').next().unwrap().to_string()
298+
/// Extracts the first part of a function name
299+
/// 'foo(bar)' -> 'foo'
300+
fn extract_function_name(expr: &Expr) -> String {
301+
let name = expr.schema_name().to_string();
302+
name.split('(').next().unwrap().to_string()
303+
}
304304
}
305305

306306
/// return a `SessionContext` with `MyHigherOrderUDF` registered as a higher-order UDF
@@ -386,9 +386,6 @@ fn test_higher_order_serialization_roundtrip() {
386386
let deserialize =
387387
parse_expr(&proto, ctx.task_ctx().as_ref(), &extension_codec).unwrap();
388388

389-
let serialize_name = extract_function_name(&expr);
390-
let deserialize_name = extract_function_name(&deserialize);
391-
392-
assert_eq!(serialize_name, deserialize_name);
389+
assert_eq!(deserialize, expr);
393390
}
394391
}

0 commit comments

Comments
 (0)