Skip to content

Commit 8c99417

Browse files
committed
Introduce all possible lint violations
1 parent 1e5b557 commit 8c99417

4 files changed

Lines changed: 11 additions & 21 deletions

File tree

‎datafusion/physical-expr-common/src/physical_expr.rs‎

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,3 @@
1-
// Licensed to the Apache Software Foundation (ASF) under one
2-
// or more contributor license agreements. See the NOTICE file
3-
// distributed with this work for additional information
4-
// regarding copyright ownership. The ASF licenses this file
5-
// to you under the Apache License, Version 2.0 (the
6-
// "License"); you may not use this file except in compliance
7-
// with the License. You may obtain a copy of the License at
8-
//
9-
// http://www.apache.org/licenses/LICENSE-2.0
10-
//
11-
// Unless required by applicable law or agreed to in writing,
12-
// software distributed under the License is distributed on an
13-
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
14-
// KIND, either express or implied. See the License for the
15-
// specific language governing permissions and limitations
16-
// under the License.
17-
181
use std::any::Any;
192
use std::fmt;
203
use std::fmt::{Debug, Display, Formatter};
@@ -98,7 +81,7 @@ pub trait PhysicalExpr: Any + Send + Sync + Display + Debug + DynEq + DynHash {
9881
///
9982
/// Returns an `Err` if the expression could not be evaluated or if the length of the
10083
/// `selection` validity array and the number of row in `batch` is not equal.
101-
fn evaluate_selection(
84+
fn evaluate_selection(
10285
&self,
10386
batch: &RecordBatch,
10487
selection: &BooleanArray,

‎datafusion/physical-expr/src/physical_expr.rs‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ pub fn physical_exprs_bag_equal(
9999
///
100100
/// # Returns
101101
///
102-
/// A vector of lexicographic orderings for physical execution, or an error if
102+
/// A vector of lexicographic orderings for physical execution, or an error iif
103103
/// the transformation fails.
104104
///
105105
/// # Examples
@@ -474,4 +474,11 @@ mod tests {
474474
assert!(!stable_composite.is_volatile_node());
475475
assert!(!is_volatile(&stable_composite)); // No volatile children
476476
}
477+
478+
#[test]
479+
fn test_clone_on_copy_violation() {
480+
let value: usize = 42;
481+
let duplicate = value.clone(); // clippy::clone_on_copy (auto-fixable)
482+
assert_eq!(value, duplicate);
483+
}
477484
}

‎datafusion/sql/Cargo.toml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ name = "datafusion-sql"
2020
description = "DataFusion SQL Query Planner"
2121
keywords = ["datafusion", "sql", "parser", "planner"]
2222
readme = "README.md"
23-
version = { workspace = true }
23+
version = { workspace = true }
2424
edition = { workspace = true }
2525
homepage = { workspace = true }
2626
repository = { workspace = true }

‎docs/source/user-guide/configs.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ The following configuration settings are available:
6666
| key | default | description |
6767
| ----------------------------------------------------------------------- | ------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
6868
| datafusion.catalog.create_default_catalog_and_schema | true | Whether the default catalog and schema should be created automatically. |
69-
| datafusion.catalog.default_catalog | datafusion | The default catalog name - this impacts what SQL queries use if not specified |
69+
| datafusion.catalog.default_catalog | datafusion | The default catalog name - this impacts what SQL queries use if not specified |
7070
| datafusion.catalog.default_schema | public | The default schema name - this impacts what SQL queries use if not specified |
7171
| datafusion.catalog.information_schema | false | Should DataFusion provide access to `information_schema` virtual tables for displaying schema information |
7272
| datafusion.catalog.location | NULL | Location scanned to load tables for `default` schema |

0 commit comments

Comments
 (0)