Skip to content

Commit 888879d

Browse files
authored
docs: remove incorrect hash dependency claim (#27137)
## Which issue does this PR close? - Follow-up to #26191 and #26191 (comment). ## Rationale for this change The comment attributes the fresh dense hashing behavior to avoiding store-to-load dependencies, but that path never reads from the hash buffer. Keeping that explanation could mislead future tuning of `LANES`. ## What changes are included in this PR? Removes the inaccurate two-line explanation while retaining the comment that describes the helper behavior. ## What is the testing strategy for this PR? This is a comment-only change, so no new test is needed. `cargo fmt --all -- --check` and the repository pre-push checks (format, workspace Clippy, and typos) pass. ## Are there any user-facing changes? No.
1 parent 9bc5faa commit 888879d

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

‎datafusion/common/src/hash_utils.rs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -325,8 +325,6 @@ fn hash_array_primitive<T>(
325325
}
326326

327327
/// Overwrite each slot with `value.hash_one(state)`, 16 rows per iteration.
328-
/// Gathering + hashing a whole lane batch before storing keeps the independent
329-
/// hashes in flight so the pipeline isn't serialized on store-to-load deps.
330328
#[cfg(not(feature = "force_hash_collisions"))]
331329
#[inline(always)]
332330
fn hash_prim_fresh_dense<N, S>(values: &[N], hashes: &mut [u64], state: &S)

0 commit comments

Comments
 (0)