@@ -289,8 +289,7 @@ impl<T: ArrowNumericType> Accumulator for MedianAccumulator<T> {
289289 }
290290
291291 fn evaluate ( & mut self ) -> Result < ScalarValue > {
292- let d = self . all_values . clone ( ) ;
293- let median = calculate_median :: < T > ( d) ;
292+ let median = calculate_median :: < T > ( & mut self . all_values ) ;
294293 ScalarValue :: new_primitive :: < T > ( median, & self . data_type )
295294 }
296295
@@ -461,8 +460,8 @@ impl<T: ArrowNumericType + Send> GroupsAccumulator for MedianGroupsAccumulator<T
461460 // Calculate median for each group
462461 let mut evaluate_result_builder =
463462 PrimitiveBuilder :: < T > :: new ( ) . with_data_type ( self . data_type . clone ( ) ) ;
464- for values in emit_group_values {
465- let median = calculate_median :: < T > ( values) ;
463+ for mut values in emit_group_values {
464+ let median = calculate_median :: < T > ( & mut values) ;
466465 evaluate_result_builder. append_option ( median) ;
467466 }
468467
@@ -546,11 +545,11 @@ impl<T: ArrowNumericType + Debug> Accumulator for DistinctMedianAccumulator<T> {
546545 }
547546
548547 fn evaluate ( & mut self ) -> Result < ScalarValue > {
549- let d = std:: mem:: take ( & mut self . distinct_values . values )
548+ let mut d = std:: mem:: take ( & mut self . distinct_values . values )
550549 . into_iter ( )
551550 . map ( |v| v. 0 )
552551 . collect :: < Vec < _ > > ( ) ;
553- let median = calculate_median :: < T > ( d) ;
552+ let median = calculate_median :: < T > ( & mut d) ;
554553 ScalarValue :: new_primitive :: < T > ( median, & self . data_type )
555554 }
556555
@@ -575,7 +574,7 @@ where
575574}
576575
577576fn calculate_median < T : ArrowNumericType > (
578- mut values : Vec < T :: Native > ,
577+ values : & mut [ T :: Native ] ,
579578) -> Option < T :: Native > {
580579 let cmp = |x : & T :: Native , y : & T :: Native | x. compare ( * y) ;
581580
0 commit comments