Skip to content

Commit 7c44e30

Browse files
adriangbclaude
andcommitted
fix: wrap DynamicFilter with Optional(...) in statistics_registry.slt
The HashJoin-generated dynamic filters on this branch are rendered as Optional(DynamicFilter [...]) now; update the two expected plans in statistics_registry.slt to match. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
1 parent f29364d commit 7c44e30

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

‎datafusion/sqllogictest/test_files/statistics_registry.slt‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,9 @@ physical_plan
104104
02)--RepartitionExec: partitioning=Hash([small_id@2], 4), input_partitions=1
105105
03)----HashJoinExec: mode=Partitioned, join_type=Inner, on=[(customer_id@0, customer_id@1)], projection=[region_id@1, order_id@2, small_id@4]
106106
04)------DataSourceExec: file_groups={1 group: [[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/statistics_registry/customers.parquet]]}, projection=[customer_id, region_id], file_type=parquet
107-
05)------DataSourceExec: file_groups={1 group: [[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/statistics_registry/orders.parquet]]}, projection=[order_id, customer_id, small_id], file_type=parquet, predicate=DynamicFilter [ empty ]
107+
05)------DataSourceExec: file_groups={1 group: [[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/statistics_registry/orders.parquet]]}, projection=[order_id, customer_id, small_id], file_type=parquet, predicate=Optional(DynamicFilter [ empty ])
108108
06)--RepartitionExec: partitioning=Hash([small_id@0], 4), input_partitions=1
109-
07)----DataSourceExec: file_groups={1 group: [[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/statistics_registry/dim_small.parquet]]}, projection=[small_id, label], file_type=parquet, predicate=DynamicFilter [ empty ]
109+
07)----DataSourceExec: file_groups={1 group: [[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/statistics_registry/dim_small.parquet]]}, projection=[small_id, label], file_type=parquet, predicate=Optional(DynamicFilter [ empty ])
110110

111111
# -- With registry -----------------------------------------------------------
112112
# Conservative estimate 100 > 50: dim_small correctly swapped to build side
@@ -127,7 +127,7 @@ physical_plan
127127
04)--RepartitionExec: partitioning=Hash([small_id@2], 4), input_partitions=1
128128
05)----HashJoinExec: mode=Partitioned, join_type=Inner, on=[(customer_id@0, customer_id@1)], projection=[region_id@1, order_id@2, small_id@4]
129129
06)------DataSourceExec: file_groups={1 group: [[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/statistics_registry/customers.parquet]]}, projection=[customer_id, region_id], file_type=parquet
130-
07)------DataSourceExec: file_groups={1 group: [[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/statistics_registry/orders.parquet]]}, projection=[order_id, customer_id, small_id], file_type=parquet, predicate=DynamicFilter [ empty ] AND DynamicFilter [ empty ]
130+
07)------DataSourceExec: file_groups={1 group: [[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/statistics_registry/orders.parquet]]}, projection=[order_id, customer_id, small_id], file_type=parquet, predicate=Optional(DynamicFilter [ empty ]) AND Optional(DynamicFilter [ empty ])
131131

132132
# -- Verify results are identical regardless of join order --------------------
133133

0 commit comments

Comments
 (0)