Skip to content

Commit 701fddc

Browse files
committed
Minor cleanup.
1 parent 4c3e5fc commit 701fddc

1 file changed

Lines changed: 4 additions & 7 deletions

File tree

‎datafusion/physical-plan/src/joins/sort_merge_join/materializing_stream.rs‎

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1215,18 +1215,15 @@ impl MaterializingSortMergeJoinStream {
12151215
return Ok(());
12161216
}
12171217

1218-
// For buffered row which is joined with streamed side rows but all joined rows
1219-
// don't satisfy the join filter
1218+
// Collect buffered rows that matched on join keys but had every
1219+
// filter evaluation fail — these must be emitted with NULLs on
1220+
// the streamed side to satisfy full outer join semantics.
12201221
let not_matched_buffered_indices = buffered_batch
12211222
.join_filter_status
12221223
.iter()
12231224
.enumerate()
12241225
.filter_map(|(i, state)| {
1225-
if *state == FilterState::AllFailed {
1226-
Some(i as u64)
1227-
} else {
1228-
None
1229-
}
1226+
matches!(state, FilterState::AllFailed).then_some(i as u64)
12301227
})
12311228
.collect::<Vec<_>>();
12321229

0 commit comments

Comments
 (0)