Repository navigation
Commit 64871d9
authored
perf: Improve efficiency of
## Which issue does this PR close?
- Closes #25426.
## Rationale for this change
When one argument of `array_has_any` is a scalar and the element type is
not a string, the fast path `array_has_any_with_scalar_general`
row-converts the list column's full child array, which does a lot of
unnecessary work for sliced lists.
Benchmarks:
- array_has_any_scalar/i64_no_match_sliced/1: 4.14 ms -> 167.4 µs,
−96.0%
- array_has_any_scalar/i64_no_match_sliced/10: 4.11 ms -> 125.9 µs,
−96.9%
- array_has_any_scalar/i64_no_match_sliced/100: 4.25 ms -> 257.8 µs,
−93.9%
- array_has_any_scalar/i64_no_match_sliced/1000: 4.12 ms -> 141.1 µs,
−96.6%
Results on unsliced inputs were unchanged, within run-to-run noise.
## What changes are included in this PR?
* Improve `array_has_any_with_scalar_general` to only touch the visible
portion of the input list
* Add a benchmark
* Add unit tests for correct behavior on sliced lists
## What is the testing strategy for this PR?
Existing tests pass, new tests added. Benchmark confirms that the
inefficiency has been addressed.
## Are there any user-facing changes?
No.array_has_any on sliced lists (#25427)1 parent bacbf2a commit 64871d9
2 files changed
Lines changed: 139 additions & 32 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
913 | 913 | | |
914 | 914 | | |
915 | 915 | | |
916 | | - | |
917 | | - | |
918 | | - | |
919 | | - | |
920 | | - | |
921 | | - | |
922 | | - | |
923 | | - | |
924 | | - | |
925 | | - | |
926 | | - | |
927 | | - | |
928 | | - | |
929 | | - | |
930 | | - | |
931 | | - | |
932 | | - | |
933 | | - | |
934 | | - | |
935 | | - | |
936 | | - | |
937 | | - | |
938 | | - | |
939 | | - | |
940 | | - | |
| 916 | + | |
| 917 | + | |
| 918 | + | |
| 919 | + | |
| 920 | + | |
| 921 | + | |
| 922 | + | |
| 923 | + | |
| 924 | + | |
| 925 | + | |
| 926 | + | |
| 927 | + | |
| 928 | + | |
| 929 | + | |
| 930 | + | |
| 931 | + | |
| 932 | + | |
| 933 | + | |
| 934 | + | |
| 935 | + | |
| 936 | + | |
| 937 | + | |
| 938 | + | |
| 939 | + | |
| 940 | + | |
| 941 | + | |
| 942 | + | |
| 943 | + | |
| 944 | + | |
| 945 | + | |
| 946 | + | |
| 947 | + | |
| 948 | + | |
| 949 | + | |
| 950 | + | |
| 951 | + | |
941 | 952 | | |
942 | 953 | | |
943 | 954 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
966 | 966 | | |
967 | 967 | | |
968 | 968 | | |
969 | | - | |
970 | 969 | | |
971 | 970 | | |
972 | 971 | | |
| 972 | + | |
| 973 | + | |
| 974 | + | |
| 975 | + | |
| 976 | + | |
| 977 | + | |
| 978 | + | |
| 979 | + | |
973 | 980 | | |
974 | 981 | | |
975 | 982 | | |
| |||
984 | 991 | | |
985 | 992 | | |
986 | 993 | | |
987 | | - | |
988 | | - | |
| 994 | + | |
| 995 | + | |
989 | 996 | | |
990 | 997 | | |
991 | 998 | | |
| |||
997 | 1004 | | |
998 | 1005 | | |
999 | 1006 | | |
1000 | | - | |
1001 | | - | |
| 1007 | + | |
| 1008 | + | |
1002 | 1009 | | |
1003 | 1010 | | |
1004 | 1011 | | |
| |||
1216 | 1223 | | |
1217 | 1224 | | |
1218 | 1225 | | |
1219 | | - | |
1220 | | - | |
| 1226 | + | |
| 1227 | + | |
1221 | 1228 | | |
1222 | 1229 | | |
1223 | 1230 | | |
| |||
1683 | 1690 | | |
1684 | 1691 | | |
1685 | 1692 | | |
| 1693 | + | |
| 1694 | + | |
| 1695 | + | |
| 1696 | + | |
| 1697 | + | |
| 1698 | + | |
| 1699 | + | |
| 1700 | + | |
| 1701 | + | |
| 1702 | + | |
| 1703 | + | |
| 1704 | + | |
| 1705 | + | |
| 1706 | + | |
| 1707 | + | |
| 1708 | + | |
| 1709 | + | |
| 1710 | + | |
| 1711 | + | |
| 1712 | + | |
| 1713 | + | |
| 1714 | + | |
| 1715 | + | |
| 1716 | + | |
| 1717 | + | |
| 1718 | + | |
| 1719 | + | |
| 1720 | + | |
| 1721 | + | |
| 1722 | + | |
| 1723 | + | |
| 1724 | + | |
| 1725 | + | |
| 1726 | + | |
| 1727 | + | |
| 1728 | + | |
| 1729 | + | |
| 1730 | + | |
| 1731 | + | |
| 1732 | + | |
| 1733 | + | |
| 1734 | + | |
| 1735 | + | |
| 1736 | + | |
| 1737 | + | |
| 1738 | + | |
| 1739 | + | |
| 1740 | + | |
| 1741 | + | |
| 1742 | + | |
| 1743 | + | |
| 1744 | + | |
| 1745 | + | |
| 1746 | + | |
| 1747 | + | |
| 1748 | + | |
| 1749 | + | |
| 1750 | + | |
| 1751 | + | |
| 1752 | + | |
| 1753 | + | |
| 1754 | + | |
| 1755 | + | |
| 1756 | + | |
| 1757 | + | |
| 1758 | + | |
| 1759 | + | |
| 1760 | + | |
| 1761 | + | |
| 1762 | + | |
| 1763 | + | |
| 1764 | + | |
| 1765 | + | |
| 1766 | + | |
| 1767 | + | |
| 1768 | + | |
| 1769 | + | |
| 1770 | + | |
| 1771 | + | |
| 1772 | + | |
| 1773 | + | |
| 1774 | + | |
| 1775 | + | |
| 1776 | + | |
| 1777 | + | |
| 1778 | + | |
| 1779 | + | |
| 1780 | + | |
| 1781 | + | |
1686 | 1782 | | |
0 commit comments