Skip to content

Commit 611311c

Browse files
authored
minor: speedup one SPM unit test (#26929)
> [!IMPORTANT] > > **Fork CI setup:** For pull requests from a fork to `main`, enable workflows in your fork's **Actions** tab before you push. > See the [fork CI setup guide](https://datafusion.apache.org/contributor-guide/#pull-requests-from-forks). ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #. ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. Please explain the problem you are trying to solve in terms of the user-visible behavior, rather than the implementation. For example, "The code in `foo.rs` doesn't handle nulls" is a symptom of the implementation. "COUNT(DISTINCT) returns wrong results when the column contains nulls" is the user-visible problem. --> Make one UT faster while preserving the test goal. The goal is preserved since no assertion requires update. ``` cargo nextest run -p datafusion-physical-plan --lib --test-threads 1 test_round_robin_tie_breaker_ Success case: 7.093s → 1.846s Failure case: 0.520s → 0.532s ``` ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here, but it is sometimes worth providing a summary of the individual changes in this PR. --> ## What is the testing strategy for this PR? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code Briefly describe how this PR is tested, and point to the specific tests you added. For example: 'This new feature is covered by the `sqllogictest` cases added in `foo.slt`'. If this PR does not add tests, explain why. For example, if the change is already covered by existing tests, please mention it. You should also check the `codecov` bot reply on this PR to confirm the changed code is exercised. --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please add the `api change` label. -->
1 parent 0ad5049 commit 611311c

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎datafusion/physical-plan/src/sorts/sort_preserving_merge.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -908,7 +908,7 @@ mod tests {
908908
let rb = RecordBatch::try_from_iter(vec![("a", a), ("b", b), ("c", c)])?;
909909
let schema = rb.schema();
910910

911-
let rbs = std::iter::repeat_n(rb, 1024).collect::<Vec<_>>();
911+
let rbs = std::iter::repeat_n(rb, 256).collect::<Vec<_>>();
912912
let sort = [
913913
PhysicalSortExpr {
914914
expr: col("b", &schema)?,

0 commit comments

Comments
 (0)