Skip to content

Commit 5f2b7f1

Browse files
committed
refactor: rename engine to registry in operator_statistics tests
1 parent e4df630 commit 5f2b7f1

1 file changed

Lines changed: 22 additions & 22 deletions

File tree

  • datafusion/physical-plan/src/operator_statistics

‎datafusion/physical-plan/src/operator_statistics/mod.rs‎

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1208,10 +1208,10 @@ mod tests {
12081208

12091209
#[test]
12101210
fn test_default_provider() -> Result<()> {
1211-
let engine = StatisticsRegistry::new();
1211+
let registry = StatisticsRegistry::new();
12121212
let source = make_source(1000);
12131213

1214-
let stats = compute(&engine, source.as_ref())?;
1214+
let stats = compute(&registry, source.as_ref())?;
12151215
assert!(matches!(stats.base.num_rows, Precision::Exact(1000)));
12161216
Ok(())
12171217
}
@@ -1331,13 +1331,13 @@ mod tests {
13311331

13321332
#[test]
13331333
fn test_custom_provider_for_custom_exec() -> Result<()> {
1334-
let mut engine = StatisticsRegistry::new();
1335-
engine.register(Arc::new(CustomStatisticsProvider));
1334+
let mut registry = StatisticsRegistry::new();
1335+
registry.register(Arc::new(CustomStatisticsProvider));
13361336

13371337
let source = make_source(1000);
13381338
let custom: Arc<dyn ExecutionPlan> = Arc::new(CustomExec { input: source });
13391339

1340-
let stats = compute(&engine, custom.as_ref())?;
1340+
let stats = compute(&registry, custom.as_ref())?;
13411341
assert!(matches!(stats.base.num_rows, Precision::Exact(1000)));
13421342
Ok(())
13431343
}
@@ -1370,15 +1370,15 @@ mod tests {
13701370

13711371
#[test]
13721372
fn test_provider_opts_out_of_child_stats() -> Result<()> {
1373-
let mut engine = StatisticsRegistry::new();
1374-
engine.register(Arc::new(NoChildStatsProvider));
1373+
let mut registry = StatisticsRegistry::new();
1374+
registry.register(Arc::new(NoChildStatsProvider));
13751375

13761376
let source = make_source(1000);
13771377
let custom: Arc<dyn ExecutionPlan> = Arc::new(CustomExec { input: source });
13781378

13791379
// The provider requested no children, so it sees the unknown placeholder
13801380
// rather than the source's row count.
1381-
let stats = compute(&engine, custom.as_ref())?;
1381+
let stats = compute(&registry, custom.as_ref())?;
13821382
assert!(stats.base.num_rows.get_value().is_none());
13831383
Ok(())
13841384
}
@@ -1418,29 +1418,29 @@ mod tests {
14181418

14191419
#[test]
14201420
fn test_override_builtin_operator() -> Result<()> {
1421-
let mut engine = StatisticsRegistry::new();
1422-
engine.register(Arc::new(OverrideFilterProvider {
1421+
let mut registry = StatisticsRegistry::new();
1422+
registry.register(Arc::new(OverrideFilterProvider {
14231423
fixed_selectivity: 0.1,
14241424
}));
14251425

14261426
let source = make_source(1000);
14271427
let filter: Arc<dyn ExecutionPlan> =
14281428
Arc::new(FilterExec::try_new(lit(true), source)?);
14291429

1430-
let stats = compute(&engine, filter.as_ref())?;
1430+
let stats = compute(&registry, filter.as_ref())?;
14311431
assert!(matches!(stats.base.num_rows, Precision::Inexact(100)));
14321432
Ok(())
14331433
}
14341434

14351435
#[test]
14361436
fn test_filter_statistics_propagation() -> Result<()> {
1437-
let engine = StatisticsRegistry::new();
1437+
let registry = StatisticsRegistry::new();
14381438
let source = make_source(1000);
14391439
let predicate = lit(true);
14401440
let filter: Arc<dyn ExecutionPlan> =
14411441
Arc::new(FilterExec::try_new(predicate, source)?);
14421442

1443-
let stats = compute(&engine, filter.as_ref())?;
1443+
let stats = compute(&registry, filter.as_ref())?;
14441444
assert!(stats.base.num_rows.get_value().unwrap_or(&0) <= &1000);
14451445
Ok(())
14461446
}
@@ -1520,15 +1520,15 @@ mod tests {
15201520

15211521
#[test]
15221522
fn test_projection_statistics_propagation() -> Result<()> {
1523-
let engine = StatisticsRegistry::new();
1523+
let registry = StatisticsRegistry::new();
15241524
let source = make_source(1000);
15251525
let schema = make_schema();
15261526
let proj: Arc<dyn ExecutionPlan> = Arc::new(ProjectionExec::try_new(
15271527
vec![(col("a", &schema)?, "a".to_string())],
15281528
source,
15291529
)?);
15301530

1531-
let stats = compute(&engine, proj.as_ref())?;
1531+
let stats = compute(&registry, proj.as_ref())?;
15321532
assert!(matches!(stats.base.num_rows, Precision::Exact(1000)));
15331533
Ok(())
15341534
}
@@ -1537,38 +1537,38 @@ mod tests {
15371537
fn test_passthrough_statistics_propagation() -> Result<()> {
15381538
use crate::coalesce_partitions::CoalescePartitionsExec;
15391539

1540-
let engine = StatisticsRegistry::new();
1540+
let registry = StatisticsRegistry::new();
15411541
let source = make_source(1000);
15421542
let coalesce: Arc<dyn ExecutionPlan> =
15431543
Arc::new(CoalescePartitionsExec::new(source));
15441544

1545-
let stats = compute(&engine, coalesce.as_ref())?;
1545+
let stats = compute(&registry, coalesce.as_ref())?;
15461546
// PassthroughStatisticsProvider should propagate child row count unchanged
15471547
assert_eq!(stats.base.num_rows, Precision::Exact(1000));
15481548
Ok(())
15491549
}
15501550

15511551
#[test]
15521552
fn test_chain_priority() -> Result<()> {
1553-
let mut engine = StatisticsRegistry::new();
1554-
engine.register(Arc::new(OverrideFilterProvider {
1553+
let mut registry = StatisticsRegistry::new();
1554+
registry.register(Arc::new(OverrideFilterProvider {
15551555
fixed_selectivity: 0.5,
15561556
}));
1557-
engine.register(Arc::new(CustomStatisticsProvider));
1557+
registry.register(Arc::new(CustomStatisticsProvider));
15581558

15591559
let source = make_source(1000);
15601560

15611561
// CustomExec handled by CustomStatisticsProvider
15621562
let custom: Arc<dyn ExecutionPlan> = Arc::new(CustomExec {
15631563
input: Arc::clone(&source),
15641564
});
1565-
let stats = compute(&engine, custom.as_ref())?;
1565+
let stats = compute(&registry, custom.as_ref())?;
15661566
assert!(matches!(stats.base.num_rows, Precision::Exact(1000)));
15671567

15681568
// FilterExec: CustomStatisticsProvider delegates, OverrideFilterProvider handles
15691569
let filter: Arc<dyn ExecutionPlan> =
15701570
Arc::new(FilterExec::try_new(lit(true), source)?);
1571-
let stats = compute(&engine, filter.as_ref())?;
1571+
let stats = compute(&registry, filter.as_ref())?;
15721572
assert!(matches!(stats.base.num_rows, Precision::Inexact(500)));
15731573

15741574
Ok(())

0 commit comments

Comments
 (0)