@@ -708,9 +708,9 @@ pub trait AggregateUDFImpl: Debug + DynEq + DynHash + Send + Sync {
708708
709709 /// Rewrite the aggregate to have simpler arguments
710710 ///
711- /// This query pattern is not common in most real workloads; Most aggregate
712- /// implementations can safely ignore this . This API is included in
713- /// DataFusion because it is important for " ClickBench Q29" . See backstory
711+ /// This query pattern is not common in most real workloads, and most
712+ /// aggregate implementations can safely ignore it . This API is included in
713+ /// DataFusion because it is important for ClickBench Q29. See backstory
714714 /// on <https://github.com/apache/datafusion/issues/15524>
715715 ///
716716 /// # Rewrite Overview
@@ -733,10 +733,10 @@ pub trait AggregateUDFImpl: Debug + DynEq + DynHash + Send + Sync {
733733 /// * `Projection(_A + 1*_B, _A + 2*_B)`
734734 /// * ` Aggregate(_A = SUM(x), _B = COUNT(x))`
735735 ///
736- /// This optimization is extremely important for Clickbench Q29 which has 90
736+ /// This optimization is extremely important for ClickBench Q29, which has 90
737737 /// such expressions for some reason, and so this optimization results in
738738 /// only two aggregates being needed. The DataFusion optimizer will invoke
739- /// this method when it detects multiple aggregates in a query that share a
739+ /// this method when it detects multiple aggregates in a query that share
740740 /// arguments of the form `<arg> <op> <literal>`.
741741 ///
742742 /// # API
@@ -747,7 +747,7 @@ pub trait AggregateUDFImpl: Debug + DynEq + DynHash + Send + Sync {
747747 ///
748748 /// This is only called when:
749749 /// 1. There are no "special" aggregate params (filters, null handling, etc)
750- /// 2. Aggregate functions with exactly one Expr argument
750+ /// 2. Aggregate functions with exactly one [` Expr`] argument
751751 /// 3. There are no volatile expressions
752752 ///
753753 /// The default implementation returns `None`, which is what most aggregates
0 commit comments