Repository navigation
Commit 4af8735
committed
fix: correct stale comments and vacuous-batch gaps from review
An Opus-model review of 131796d caught three loose ends:
- The SchemaConformingStream/conform_stream_schema doc comment claimed
InterleaveExec::try_new re-validates child field data types the same
way UnionExec::try_new does via calculate_union. It doesn't --
InterleaveExec::compute_properties builds fresh EquivalenceProperties
without that check. Corrected the comment to state the real
invariant (InterleaveExec inputs come from an already-validated
UnionExec via the optimizer) and note that a genuine mismatch would
now surface as an explicit error rather than a silently corrupt batch.
- test_interleave_conforms_batch_schema and
union_all_widening_cast_also_fixes_nullable iterated collected
batches without asserting the batch list was non-empty, so both
could pass vacuously if no rows came through.
- union_nullable_spill.rs's regression test doc comment asserted
UnionExec returns child streams "without schema coercion" -- no
longer true after this fix. Updated it to explain the test now
guards the SpillManager-level fix (#21292) specifically, since
UnionExec itself no longer produces mismatched-nullability batches.1 parent 131796d commit 4af8735
3 files changed
Lines changed: 33 additions & 22 deletions
File tree
- datafusion
- core/tests
- memory_limit
- sql
- physical-plan/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
110 | 115 | | |
111 | 116 | | |
112 | 117 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
83 | | - | |
| 83 | + | |
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | | - | |
| 96 | + | |
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
| |||
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
118 | | - | |
119 | | - | |
| 118 | + | |
120 | 119 | | |
121 | 120 | | |
122 | 121 | | |
| |||
127 | 126 | | |
128 | 127 | | |
129 | 128 | | |
130 | | - | |
131 | | - | |
| 129 | + | |
132 | 130 | | |
133 | 131 | | |
134 | 132 | | |
| |||
138 | 136 | | |
139 | 137 | | |
140 | 138 | | |
141 | | - | |
| 139 | + | |
142 | 140 | | |
143 | 141 | | |
144 | 142 | | |
| |||
190 | 188 | | |
191 | 189 | | |
192 | 190 | | |
193 | | - | |
| 191 | + | |
194 | 192 | | |
195 | 193 | | |
196 | 194 | | |
197 | 195 | | |
198 | 196 | | |
199 | 197 | | |
200 | 198 | | |
| 199 | + | |
201 | 200 | | |
202 | 201 | | |
203 | 202 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
79 | 84 | | |
80 | 85 | | |
81 | 86 | | |
| |||
1094 | 1099 | | |
1095 | 1100 | | |
1096 | 1101 | | |
1097 | | - | |
| 1102 | + | |
| 1103 | + | |
| 1104 | + | |
1098 | 1105 | | |
1099 | 1106 | | |
1100 | 1107 | | |
| |||
0 commit comments