Skip to content

Commit 48adae4

Browse files
authored
Revert addition of benchmark_runner for sql_benchmarks (#22624)
This reverts commit 32f51ec ## Which issue does this PR close? - Reverts #22001 ## Rationale for this change After reviewing the full changeset for this feature I'm dissatisfied with the quality of the code and the featureset. Thus I wish to revert the initial commit. I may try again in the future but if anyone else wants to cleanup/factor/etc the full feature let me know and I'll post up in a branch in my repo. ## What changes are included in this PR? reverting code. ## Are these changes tested? ./dev/rust_lint.sh passed. ## Are there any user-facing changes? No.
1 parent d070a8b commit 48adae4

9 files changed

Lines changed: 1 addition & 946 deletions

File tree

‎Cargo.lock‎

Lines changed: 0 additions & 32 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎benchmarks/Cargo.toml‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,10 @@ snmalloc = ["snmalloc-rs"]
4040
mimalloc_extended = ["libmimalloc-sys/extended"]
4141

4242
[dependencies]
43-
anstream = "1.0"
4443
arrow = { workspace = true }
4544
async-trait = "0.1"
4645
bytes = { workspace = true }
47-
clap = { version = "4.6.1", features = ["derive", "env", "color"] }
46+
clap = { version = "4.6.0", features = ["derive", "env"] }
4847
criterion = { workspace = true, features = ["html_reports"] }
4948
datafusion = { workspace = true, default-features = true }
5049
datafusion-common = { workspace = true, default-features = true }
@@ -62,7 +61,6 @@ serde_json = { workspace = true }
6261
snmalloc-rs = { version = "0.7", optional = true }
6362
tokio = { workspace = true, features = ["rt-multi-thread", "parking_lot"] }
6463
tokio-util = { version = "0.7.17" }
65-
toml = "1.1"
6664

6765
[dev-dependencies]
6866
datafusion-proto = { workspace = true }

‎benchmarks/sql_benchmarks/tpch/tpch.suite‎

Lines changed: 0 additions & 16 deletions
This file was deleted.

‎benchmarks/src/benchmark_runner/cli.rs‎

Lines changed: 0 additions & 81 deletions
This file was deleted.

‎benchmarks/src/benchmark_runner/mod.rs‎

Lines changed: 0 additions & 104 deletions
This file was deleted.

0 commit comments

Comments
 (0)