Skip to content

Commit 4648c72

Browse files
committed
test(cli): move recursion_limit coverage into select.sql fixture
Fold the recursion_limit statements into the existing tests/sql/select.sql fixture covered by [email protected], and drop the separate fixture, test case and snapshot.
1 parent 4ebde0b commit 4648c72

5 files changed

Lines changed: 12 additions & 29 deletions

File tree

‎datafusion-cli/tests/cli_integration.rs‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -326,10 +326,6 @@ fn init() {
326326
"change_format_version",
327327
["--file", "tests/sql/types_format.sql", "-q"],
328328
)]
329-
#[case::recursion_limit(
330-
"recursion_limit",
331-
["--file", "tests/sql/recursion_limit.sql", "-q"],
332-
)]
333329
#[test]
334330
fn cli_quick_test<'a>(
335331
#[case] snapshot_name: &'a str,

‎datafusion-cli/tests/snapshots/[email protected]‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,11 @@ exit_code: 0
1515
+----------+
1616
| 1 |
1717
+----------+
18+
+------+
19+
| deep |
20+
+------+
21+
| 1 |
22+
+------+
1823

1924
----- stderr -----
25+
SQL error: RecursionLimitExceeded (current limit: 5)

‎datafusion-cli/tests/snapshots/cli_quick_test@recursion_limit.snap‎

Lines changed: 0 additions & 20 deletions
This file was deleted.

‎datafusion-cli/tests/sql/recursion_limit.sql‎

Lines changed: 0 additions & 4 deletions
This file was deleted.
Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,6 @@
1-
select 1;
1+
select 1;
2+
-- datafusion.sql_parser.recursion_limit is respected when parsing (#24913)
3+
set datafusion.sql_parser.recursion_limit = 100;
4+
select abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(1)))))))))))))))))))))))))))))))))))))))))))))))))))))))))))) as deep;
5+
set datafusion.sql_parser.recursion_limit = 5;
6+
select abs(abs(abs(abs(abs(abs(abs(abs(abs(abs(1)))))))))) as shallow;

0 commit comments

Comments
 (0)