1919
2020use crate :: utils:: make_scalar_function;
2121use arrow:: array:: {
22- Array , ArrayRef , Float64Array , GenericListArray , NullBufferBuilder ,
23- OffsetBufferBuilder , OffsetSizeTrait ,
22+ Array , ArrayRef , Float64Array , GenericListArray , NullBufferBuilder , OffsetSizeTrait ,
2423} ;
24+ use arrow:: buffer:: OffsetBuffer ;
2525use arrow:: datatypes:: {
2626 DataType ,
2727 DataType :: { FixedSizeList , LargeList , List , Null } ,
@@ -144,13 +144,14 @@ fn general_array_normalize<O: OffsetSizeTrait>(arrays: &[ArrayRef]) -> Result<Ar
144144 let offsets = list_array. value_offsets ( ) ;
145145
146146 let mut new_values: Vec < f64 > = Vec :: with_capacity ( values. len ( ) ) ;
147- let mut new_offsets = OffsetBufferBuilder :: < O > :: new ( list_array. len ( ) ) ;
147+ let mut new_offsets = Vec :: < O > :: with_capacity ( list_array. len ( ) + 1 ) ;
148+ new_offsets. push ( O :: zero ( ) ) ;
148149 let mut nulls = NullBufferBuilder :: new ( list_array. len ( ) ) ;
149150
150151 for row in 0 ..list_array. len ( ) {
151152 if list_array. is_null ( row) {
152153 nulls. append_null ( ) ;
153- new_offsets. push_length ( 0 ) ;
154+ new_offsets. push ( new_offsets [ row ] ) ;
154155 continue ;
155156 }
156157
@@ -161,7 +162,7 @@ fn general_array_normalize<O: OffsetSizeTrait>(arrays: &[ArrayRef]) -> Result<Ar
161162 let slice = values. slice ( start, len) ;
162163 if slice. null_count ( ) != 0 {
163164 nulls. append_null ( ) ;
164- new_offsets. push_length ( 0 ) ;
165+ new_offsets. push ( new_offsets [ row ] ) ;
165166 continue ;
166167 }
167168
@@ -170,7 +171,7 @@ fn general_array_normalize<O: OffsetSizeTrait>(arrays: &[ArrayRef]) -> Result<Ar
170171 // Empty array: return empty array (no normalization needed, no division by zero risk)
171172 if len == 0 {
172173 nulls. append_non_null ( ) ;
173- new_offsets. push_length ( 0 ) ;
174+ new_offsets. push ( new_offsets [ row ] ) ;
174175 continue ;
175176 }
176177
@@ -183,7 +184,7 @@ fn general_array_normalize<O: OffsetSizeTrait>(arrays: &[ArrayRef]) -> Result<Ar
183184 // Zero magnitude: undefined normalization. Emit NULL row.
184185 if sq_sum == 0.0 {
185186 nulls. append_null ( ) ;
186- new_offsets. push_length ( 0 ) ;
187+ new_offsets. push ( new_offsets [ row ] ) ;
187188 continue ;
188189 }
189190
@@ -192,15 +193,15 @@ fn general_array_normalize<O: OffsetSizeTrait>(arrays: &[ArrayRef]) -> Result<Ar
192193 new_values. push ( vals[ i] / mag) ;
193194 }
194195 nulls. append_non_null ( ) ;
195- new_offsets. push_length ( len) ;
196+ new_offsets. push ( new_offsets [ row ] + O :: usize_as ( len) ) ;
196197 }
197198
198199 let values_array = Arc :: new ( Float64Array :: from ( new_values) ) ;
199200 let field = Arc :: new ( Field :: new_list_field ( DataType :: Float64 , true ) ) ;
200201
201202 Ok ( Arc :: new ( GenericListArray :: < O > :: try_new (
202203 field,
203- new_offsets. finish ( ) ,
204+ OffsetBuffer :: new ( new_offsets. into ( ) ) ,
204205 values_array,
205206 nulls. finish ( ) ,
206207 ) ?) )
0 commit comments