Repository navigation
Commit 41d9edc
test: cover the nested shape Absolute could invent a limit in
Review asked about a nested window below a sort the rule had already given
a fetch to. The test that landed earlier used the smallest shape that
reaches the arm -- one window, no limit anywhere -- so the nested shape the
review described had no test of its own. This adds it: the limit is spent
on the outer sort, so the inner window reaches `grow_limit` with nothing in
hand and the inner sort has no `LIMIT` above it at all.
The arm now has three tests. The two that assert a full sort are not
redundant, because the shapes differ in when they became reachable.
Reverting only the `Absolute` fix turns both red. Also reverting
`Transformed::yes` to `Transformed::complete`, which is what `main` does,
leaves the nested test green and the single-window test red: `Stop` kept
the walk out of everything below an applied sort, so the nested shape is
reachable only once the walk continues, while the single-window shape needs
no nesting and is reachable on `main` as it stands. That is the split
behind the one-line "pre-existing" in the `Absolute` commit: it holds for
the shape that commit tested, not for the nested one review raised.
Co-Authored-By: Claude Opus 5 <[email protected]>1 parent 01dd163 commit 41d9edc
1 file changed
Lines changed: 33 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
443 | 443 | | |
444 | 444 | | |
445 | 445 | | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
446 | 462 | | |
447 | 463 | | |
448 | 464 | | |
| |||
469 | 485 | | |
470 | 486 | | |
471 | 487 | | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
472 | 505 | | |
0 commit comments