You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 41026ca
Browse filesBrowse the repository at this point in the historyBrowse files
fix: address review feedback on null-aware value key counts
- Check the join type, partition mode and an empty `on` before the value
key count, so a null-aware join no count can fix reports its real error
instead of asking for `with_null_aware_value_keys`.
- Decorrelation sets the count only on a null-aware join. Other joins keep
it unset, as `Join::try_new` leaves it, so equal plans compare equal.
- Both `with_null_aware_value_keys` setters take `Option<NonZeroUsize>`,
which keeps the physical planner, the proto decoders and
`eliminate_join` as plain builder chains.
- Encode the count with `usize_to_wire` and decode it with a new shared
`non_zero_usize_from_wire`, so both proto decoders reject a wire `0`
with the same plan error.
- Slim the scalar `NOT IN` test helper to the arguments that vary and
flatten a leftover block in `test_null_aware_validation_value_keys`.
Co-authored-by: Isaac <[email protected]>
0 commit comments