Skip to content

Commit 40b6c53

Browse files
committed
address pr feedback
1 parent 4ec0e6c commit 40b6c53

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

‎datafusion/optimizer/src/extract_leaf_expressions.rs‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,12 @@ use crate::push_down_filter::replace_cols_by_name;
3535
use crate::utils::has_all_column_refs;
3636
use crate::{OptimizerConfig, OptimizerRule};
3737

38+
/// Prefix for aliases generated by the extraction optimizer passes.
39+
///
40+
/// This prefix is **reserved for internal optimizer use**. User-defined aliases
41+
/// starting with this prefix may be misidentified as optimizer-generated
42+
/// extraction aliases, leading to unexpected behavior. Do not use this prefix
43+
/// in user queries.
3844
const EXTRACTED_EXPR_PREFIX: &str = "__datafusion_extracted";
3945

4046
/// Extracts `MoveTowardsLeafNodes` sub-expressions from non-projection nodes

‎datafusion/optimizer/src/optimize_projections/mod.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -565,7 +565,7 @@ fn merge_consecutive_projections(proj: Projection) -> Result<Transformed<Project
565565
// `f(x)`). Wrapping in a redundant self-alias causes a
566566
// cosmetic `f(x) AS f(x)` due to Display vs schema_name
567567
// formatting differences. Drop the alias when it matches.
568-
if expr.schema_name().to_string() == name {
568+
if metadata.is_none() && expr.schema_name().to_string() == name {
569569
expr
570570
} else {
571571
Expr::Alias(

0 commit comments

Comments
 (0)