Repository navigation
Commit 39d5064
authored
chore: refactor
## Which issue does this PR close?
Part of:
- #23974
## Rationale for this change
Simplify the code and make code similar to textbook so it is easier to
read
## What changes are included in this PR?
Changed to async generators + simplified to be similar to textbook
Most of the code was written by Claude Fable 5 since it was just too
large to comprehend in head
## Are these changes tested?
existing tests + a little more tests to verify we are not counting the
childs in the join time
## Are there any user-facing changes?
The join_time now includes the time to read from the async spill stream
between pending which is arguable more correct since this time is part
of the operator, although long waits between pending calls will be
counted in the op `join_time` while the alternative is not counting the
read from file and decoding...MaterializingSortMergeJoinStream into generators and simplify code to be textbook like as possible (#23976)1 parent 1ae6b87 commit 39d5064
3 files changed
Lines changed: 720 additions & 624 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
85 | | - | |
| 84 | + | |
86 | 85 | | |
87 | 86 | | |
88 | 87 | | |
| |||
92 | 91 | | |
93 | 92 | | |
94 | 93 | | |
95 | | - | |
96 | | - | |
| 94 | + | |
97 | 95 | | |
98 | 96 | | |
99 | 97 | | |
| |||
546 | 544 | | |
547 | 545 | | |
548 | 546 | | |
549 | | - | |
| 547 | + | |
550 | 548 | | |
551 | 549 | | |
552 | 550 | | |
| |||
561 | 559 | | |
562 | 560 | | |
563 | 561 | | |
564 | | - | |
| 562 | + | |
565 | 563 | | |
566 | 564 | | |
567 | 565 | | |
| |||
0 commit comments