Skip to content

Commit 2ee8910

Browse files
edubraqdclaude
andcommitted
review: document what None means in extract_window_frame_target_type
Co-Authored-By: Claude Opus 5 <[email protected]>
1 parent 848426d commit 2ee8910

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

‎datafusion/optimizer/src/analyzer/type_coercion.rs‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1100,7 +1100,9 @@ fn coerce_frame_bound(
11001100
}
11011101

11021102
/// The type that RANGE frame offsets are coerced to for an ORDER BY column of
1103-
/// `col_type`, or `None` if the type does not support RANGE frames.
1103+
/// `col_type`, or `None` if there is no offset type to coerce to (the column
1104+
/// type has no arithmetic). `None` does not mean the type is unusable in a
1105+
/// RANGE frame: a free frame has no offsets, see `supports_free_range_frame`.
11041106
fn extract_window_frame_target_type(col_type: &DataType) -> Option<DataType> {
11051107
if col_type.is_numeric()
11061108
|| col_type.is_string()

0 commit comments

Comments
 (0)