Repository navigation
Commit 264ee3d
authored
fix: use session statistics registry in dfbench reports (#25570)
## Which issue does this PR close?
Part of #8227.
## Rationale for this change
`dfbench statistics` unconditionally enables built-in statistics
providers, so its estimates can differ from those used by the session.
In TPC-H SF1 Q14, it reports 14.73 billion rows instead of 73,650 for a
join that produces 75,983 rows.
Unrelated to this PR, but it's pretty weird how the built-in providers
are not actually built-in unless explicitly enabled, and it's also weird
how they can override the actually built-in code in each operator
producing different results. It seems like there's different pieces of
code with overlapping intentions and different implementation.
## What changes are included in this PR?
Capture estimates using the session's registry, matching `EXPLAIN
ANALYZE`. An unconfigured session falls back to operator statistics.
## What is the testing strategy for this PR?
- All five existing CLI statistics tests, formatting, and all-feature
Clippy pass.
## Are there any user-facing changes?
CLI estimates now respect the session's statistics configuration.1 parent 23c1b59 commit 264ee3d
1 file changed
Lines changed: 51 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
184 | 184 | | |
185 | 185 | | |
186 | 186 | | |
187 | | - | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
188 | 191 | | |
189 | 192 | | |
190 | 193 | | |
| |||
248 | 251 | | |
249 | 252 | | |
250 | 253 | | |
251 | | - | |
252 | | - | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
253 | 258 | | |
254 | | - | |
| 259 | + | |
255 | 260 | | |
256 | 261 | | |
257 | 262 | | |
| |||
723 | 728 | | |
724 | 729 | | |
725 | 730 | | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
726 | 736 | | |
727 | 737 | | |
728 | 738 | | |
| |||
786 | 796 | | |
787 | 797 | | |
788 | 798 | | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
| 818 | + | |
| 819 | + | |
| 820 | + | |
| 821 | + | |
| 822 | + | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
| 826 | + | |
| 827 | + | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
| 834 | + | |
| 835 | + | |
789 | 836 | | |
790 | 837 | | |
791 | 838 | | |
| |||
0 commit comments