Skip to content

Commit 1a9821e

Browse files
authored
chore: remove denys of needless_pass_by_value in lib.rs files (#18996)
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Followup to #18904 (part of #18503) ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Lint already enforced at the workspace level so don't need to have these individual denies in each `lib.rs` (still maintain exclusion for tests though). ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Remove `#![deny(clippy::needless_pass_by_value)]` in each `lib.rs`. ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Manually tested; the lint still seems to work, e.g. when I comment out an `#[expect(clippy::needless_pass_by_value)]` then clippy still flags it due to workspace lint rules. ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> No. <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
1 parent 81512da commit 1a9821e

38 files changed

Lines changed: 1 addition & 72 deletions

File tree

‎Cargo.toml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,7 @@ or_fun_call = "warn"
197197
unnecessary_lazy_evaluations = "warn"
198198
uninlined_format_args = "warn"
199199
inefficient_to_string = "warn"
200+
# https://github.com/apache/datafusion/issues/18503
200201
needless_pass_by_value = "warn"
201202

202203
[workspace.lints.rust]

‎datafusion/catalog-listing/src/mod.rs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
// specific language governing permissions and limitations
1616
// under the License.
1717

18-
// https://github.com/apache/datafusion/issues/18503
19-
#![deny(clippy::needless_pass_by_value)]
2018
#![cfg_attr(test, allow(clippy::needless_pass_by_value))]
2119
#![doc(
2220
html_logo_url = "https://raw.githubusercontent.com/apache/datafusion/19fe44cf2f30cbdd63d4a4f52c74055163c6cc38/docs/logos/standalone_logo/logo_original.svg",

‎datafusion/catalog/src/lib.rs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
// Make sure fast / cheap clones on Arc are explicit:
2424
// https://github.com/apache/datafusion/issues/11143
2525
#![cfg_attr(not(test), deny(clippy::clone_on_ref_ptr))]
26-
#![deny(clippy::needless_pass_by_value)]
2726
#![cfg_attr(test, allow(clippy::needless_pass_by_value))]
2827
#![deny(clippy::allow_attributes)]
2928

‎datafusion/common-runtime/src/lib.rs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
// specific language governing permissions and limitations
1616
// under the License.
1717

18-
// https://github.com/apache/datafusion/issues/18503
19-
#![deny(clippy::needless_pass_by_value)]
2018
#![cfg_attr(test, allow(clippy::needless_pass_by_value))]
2119
#![deny(clippy::allow_attributes)]
2220
#![doc(

‎datafusion/common/src/lib.rs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
// Make sure fast / cheap clones on Arc are explicit:
2424
// https://github.com/apache/datafusion/issues/11143
2525
#![deny(clippy::clone_on_ref_ptr)]
26-
// https://github.com/apache/datafusion/issues/18503
27-
#![deny(clippy::needless_pass_by_value)]
2826
#![cfg_attr(test, allow(clippy::needless_pass_by_value))]
2927
#![deny(clippy::allow_attributes)]
3028

‎datafusion/core/src/lib.rs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
)
3636
)]
3737
#![warn(missing_docs, clippy::needless_borrow)]
38-
#![deny(clippy::needless_pass_by_value)]
3938
#![cfg_attr(test, allow(clippy::needless_pass_by_value))]
4039

4140
//! [DataFusion] is an extensible query engine written in Rust that

‎datafusion/datasource-arrow/src/mod.rs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
// specific language governing permissions and limitations
1616
// under the License.
1717

18-
// https://github.com/apache/datafusion/issues/18503
19-
#![deny(clippy::needless_pass_by_value)]
2018
#![cfg_attr(test, allow(clippy::needless_pass_by_value))]
2119
// Make sure fast / cheap clones on Arc are explicit:
2220
// https://github.com/apache/datafusion/issues/11143

‎datafusion/datasource-avro/src/mod.rs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
// Make sure fast / cheap clones on Arc are explicit:
2424
// https://github.com/apache/datafusion/issues/11143
2525
#![cfg_attr(not(test), deny(clippy::clone_on_ref_ptr))]
26-
#![deny(clippy::needless_pass_by_value)]
2726
#![cfg_attr(test, allow(clippy::needless_pass_by_value))]
2827

2928
//! An [Avro](https://avro.apache.org/) based [`FileSource`](datafusion_datasource::file::FileSource) implementation and related functionality.

‎datafusion/datasource-csv/src/mod.rs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
// specific language governing permissions and limitations
1616
// under the License.
1717

18-
// https://github.com/apache/datafusion/issues/18503
19-
#![deny(clippy::needless_pass_by_value)]
2018
#![cfg_attr(test, allow(clippy::needless_pass_by_value))]
2119
// Make sure fast / cheap clones on Arc are explicit:
2220
// https://github.com/apache/datafusion/issues/11143

‎datafusion/datasource-json/src/mod.rs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
// specific language governing permissions and limitations
1616
// under the License.
1717

18-
// https://github.com/apache/datafusion/issues/18503
19-
#![deny(clippy::needless_pass_by_value)]
2018
#![cfg_attr(test, allow(clippy::needless_pass_by_value))]
2119
// Make sure fast / cheap clones on Arc are explicit:
2220
// https://github.com/apache/datafusion/issues/11143

0 commit comments

Comments
 (0)