Skip to content

Commit 11e8906

Browse files
alambxudong963
andauthored
minor: port date_bin tests to sqllogictests (#5115)
* minor: port date_bin tests to sqllogictests * Add change to trigger CI * Update datafusion/core/tests/sqllogictests/test_files/timestamps.slt Co-authored-by: xudong.w <[email protected]> --------- Co-authored-by: xudong.w <[email protected]>
1 parent bd64527 commit 11e8906

2 files changed

Lines changed: 66 additions & 111 deletions

File tree

‎datafusion/core/tests/sql/timestamp.rs‎

Lines changed: 0 additions & 111 deletions
Original file line numberDiff line numberDiff line change
@@ -1243,117 +1243,6 @@ async fn to_timestamp_seconds_i32() -> Result<()> {
12431243
Ok(())
12441244
}
12451245

1246-
#[tokio::test]
1247-
async fn date_bin() {
1248-
let ctx = SessionContext::new();
1249-
1250-
let sql = "SELECT DATE_BIN(INTERVAL '15 minutes', TIMESTAMP '2022-08-03 14:38:50Z', TIMESTAMP '1970-01-01T00:00:00Z') AS res";
1251-
let results = execute_to_batches(&ctx, sql).await;
1252-
let expected = vec![
1253-
"+---------------------+",
1254-
"| res |",
1255-
"+---------------------+",
1256-
"| 2022-08-03T14:30:00 |",
1257-
"+---------------------+",
1258-
];
1259-
assert_batches_eq!(expected, &results);
1260-
1261-
// Shift forward by 5 minutes
1262-
let sql = "SELECT DATE_BIN(INTERVAL '15 minutes', TIMESTAMP '2022-08-03 14:38:50Z', TIMESTAMP '1970-01-01T00:05:00Z') AS res";
1263-
let results = execute_to_batches(&ctx, sql).await;
1264-
let expected = vec![
1265-
"+---------------------+",
1266-
"| res |",
1267-
"+---------------------+",
1268-
"| 2022-08-03T14:35:00 |",
1269-
"+---------------------+",
1270-
];
1271-
assert_batches_eq!(expected, &results);
1272-
1273-
// Shift backward by 5 minutes
1274-
let sql = "SELECT DATE_BIN(INTERVAL '15 minutes', TIMESTAMP '2022-08-03 14:38:50Z', TIMESTAMP '1970-01-01T23:55:00Z') AS res";
1275-
let results = execute_to_batches(&ctx, sql).await;
1276-
let expected = vec![
1277-
"+---------------------+",
1278-
"| res |",
1279-
"+---------------------+",
1280-
"| 2022-08-03T14:25:00 |",
1281-
"+---------------------+",
1282-
];
1283-
assert_batches_eq!(expected, &results);
1284-
1285-
// origin after source, timestamp in previous bucket
1286-
let sql = "SELECT DATE_BIN(INTERVAL '15 minutes', TIMESTAMP '2022-08-03 14:38:50Z', TIMESTAMP '2022-08-03 14:40:00Z') AS res";
1287-
let results = execute_to_batches(&ctx, sql).await;
1288-
let expected = vec![
1289-
"+---------------------+",
1290-
"| res |",
1291-
"+---------------------+",
1292-
"| 2022-08-03T14:25:00 |",
1293-
"+---------------------+",
1294-
];
1295-
assert_batches_eq!(expected, &results);
1296-
1297-
// stride by 7 days
1298-
let sql = "SELECT DATE_BIN(INTERVAL '7 days', TIMESTAMP '2022-08-03 14:38:50Z', TIMESTAMP '1970-01-01 00:00:00Z') AS res";
1299-
let results = execute_to_batches(&ctx, sql).await;
1300-
let expected = vec![
1301-
"+---------------------+",
1302-
"| res |",
1303-
"+---------------------+",
1304-
"| 2022-07-28T00:00:00 |",
1305-
"+---------------------+",
1306-
];
1307-
assert_batches_eq!(expected, &results);
1308-
1309-
// origin shifts bins forward 1 day
1310-
let sql = "SELECT DATE_BIN(INTERVAL '7 days', TIMESTAMP '2022-08-03 14:38:50Z', TIMESTAMP '1970-01-02 00:00:00Z') AS res";
1311-
let results = execute_to_batches(&ctx, sql).await;
1312-
let expected = vec![
1313-
"+---------------------+",
1314-
"| res |",
1315-
"+---------------------+",
1316-
"| 2022-07-29T00:00:00 |",
1317-
"+---------------------+",
1318-
];
1319-
assert_batches_eq!(expected, &results);
1320-
1321-
// following test demonstrates array values for the source argument
1322-
let sql = "SELECT
1323-
DATE_BIN(INTERVAL '15' minute, time, TIMESTAMP '2001-01-01T00:00:00Z') AS time,
1324-
val
1325-
FROM (
1326-
VALUES
1327-
(TIMESTAMP '2021-06-10 17:05:00Z', 0.5),
1328-
(TIMESTAMP '2021-06-10 17:19:10Z', 0.3)
1329-
) as t (time, val)";
1330-
let results = execute_to_batches(&ctx, sql).await;
1331-
let expected = vec![
1332-
"+---------------------+-----+",
1333-
"| time | val |",
1334-
"+---------------------+-----+",
1335-
"| 2021-06-10T17:00:00 | 0.5 |",
1336-
"| 2021-06-10T17:15:00 | 0.3 |",
1337-
"+---------------------+-----+",
1338-
];
1339-
assert_batches_eq!(expected, &results);
1340-
1341-
// following test demonstrates array values for the origin argument are not currently supported
1342-
let sql = "SELECT
1343-
DATE_BIN(INTERVAL '15' minute, time, origin) AS time,
1344-
val
1345-
FROM (
1346-
VALUES
1347-
(TIMESTAMP '2021-06-10 17:05:00Z', TIMESTAMP '2001-01-01T00:00:00Z', 0.5),
1348-
(TIMESTAMP '2021-06-10 17:19:10Z', TIMESTAMP '2001-01-01T00:00:00Z', 0.3)
1349-
) as t (time, origin, val)";
1350-
let result = try_execute_to_batches(&ctx, sql).await;
1351-
assert_eq!(
1352-
result.err().unwrap().to_string(),
1353-
"This feature is not implemented: DATE_BIN only supports literal values for the origin argument, not arrays"
1354-
);
1355-
}
1356-
13571246
#[tokio::test]
13581247
async fn timestamp_add_interval_second() -> Result<()> {
13591248
let ctx = SessionContext::new();

‎datafusion/core/tests/sqllogictests/test_files/timestamps.slt‎

Lines changed: 66 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,3 +67,69 @@ select * from foo where ts != '2000-02-01T00:00:00';
6767

6868
statement ok
6969
drop table foo;
70+
71+
###
72+
## test date_bin function
73+
###
74+
query T
75+
SELECT DATE_BIN(INTERVAL '15 minutes', TIMESTAMP '2022-08-03 14:38:50Z', TIMESTAMP '1970-01-01T00:00:00Z') AS res
76+
----
77+
2022-08-03T14:30:00
78+
79+
# Shift forward by 5 minutes
80+
query T
81+
SELECT DATE_BIN(INTERVAL '15 minutes', TIMESTAMP '2022-08-03 14:38:50Z', TIMESTAMP '1970-01-01T00:05:00Z') AS res
82+
----
83+
2022-08-03T14:35:00
84+
85+
86+
# Shift backward by 5 minutes
87+
query T
88+
SELECT DATE_BIN(INTERVAL '15 minutes', TIMESTAMP '2022-08-03 14:38:50Z', TIMESTAMP '1970-01-01T23:55:00Z') AS res
89+
----
90+
2022-08-03T14:25:00
91+
92+
# origin after source, timestamp in previous bucket
93+
query T
94+
SELECT DATE_BIN(INTERVAL '15 minutes', TIMESTAMP '2022-08-03 14:38:50Z', TIMESTAMP '2022-08-03 14:40:00Z') AS res
95+
----
96+
2022-08-03T14:25:00
97+
98+
# stride by 7 days
99+
query T
100+
SELECT DATE_BIN(INTERVAL '7 days', TIMESTAMP '2022-08-03 14:38:50Z', TIMESTAMP '1970-01-01 00:00:00Z') AS res
101+
----
102+
2022-07-28T00:00:00
103+
104+
105+
# origin shifts bins forward 1 day
106+
query T
107+
SELECT DATE_BIN(INTERVAL '7 days', TIMESTAMP '2022-08-03 14:38:50Z', TIMESTAMP '1970-01-02 00:00:00Z') AS res
108+
----
109+
2022-07-29T00:00:00
110+
111+
112+
# demonstrates array values (rather than scalar) for the source argument
113+
query T rowsort
114+
SELECT
115+
DATE_BIN(INTERVAL '15' minute, time, TIMESTAMP '2001-01-01T00:00:00Z') AS time,
116+
val
117+
FROM (
118+
VALUES
119+
(TIMESTAMP '2021-06-10 17:05:00Z', 0.5),
120+
(TIMESTAMP '2021-06-10 17:19:10Z', 0.3)
121+
) as t (time, val)
122+
----
123+
2021-06-10T17:00:00 0.5
124+
2021-06-10T17:15:00 0.3
125+
126+
# demonstrates array values for the origin argument are not currently supported
127+
statement error This feature is not implemented: DATE_BIN only supports literal values for the origin argument, not arrays
128+
SELECT
129+
DATE_BIN(INTERVAL '15' minute, time, origin) AS time,
130+
val
131+
FROM (
132+
VALUES
133+
(TIMESTAMP '2021-06-10 17:05:00Z', TIMESTAMP '2001-01-01T00:00:00Z', 0.5),
134+
(TIMESTAMP '2021-06-10 17:19:10Z', TIMESTAMP '2001-01-01T00:00:00Z', 0.3)
135+
) as t (time, origin, val)

0 commit comments

Comments
 (0)