Repository navigation
Commit 10ccc3e
fix: keep outer references when matching the
`PullUpCorrelatedExpr::correlated_filters` came from `find_join_exprs`,
which strips the outer references. A subquery column with the same
qualified name as the outer `IN` value then read as that value, so a
correlation such as `a.x = b.k` inside `FROM t AS a` was taken to keep a
NULL outer `a.x` out of the scope. The join was then not null-aware, and
the query gave FALSE, or kept the row under `NOT IN`, where the answer is
UNKNOWN.
Record the correlated conjuncts with their outer references, and match
each side of a conjunct against the side of the join that the key is on.
Co-Authored-By: Claude Opus 5.5 <[email protected]>IN value to a correlation1 parent 97d3cff commit 10ccc3e
3 files changed
Lines changed: 74 additions & 13 deletions
File tree
- datafusion
- optimizer/src
- sqllogictest/test_files
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
80 | 82 | | |
81 | 83 | | |
82 | 84 | | |
| |||
193 | 195 | | |
194 | 196 | | |
195 | 197 | | |
196 | | - | |
197 | | - | |
198 | | - | |
199 | | - | |
200 | | - | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
201 | 201 | | |
202 | 202 | | |
| 203 | + | |
| 204 | + | |
203 | 205 | | |
204 | 206 | | |
205 | 207 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
36 | 38 | | |
37 | 39 | | |
38 | 40 | | |
| |||
556 | 558 | | |
557 | 559 | | |
558 | 560 | | |
| 561 | + | |
559 | 562 | | |
560 | 563 | | |
561 | 564 | | |
562 | 565 | | |
| 566 | + | |
563 | 567 | | |
564 | 568 | | |
565 | 569 | | |
| |||
588 | 592 | | |
589 | 593 | | |
590 | 594 | | |
591 | | - | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
592 | 607 | | |
593 | 608 | | |
594 | 609 | | |
595 | 610 | | |
596 | 611 | | |
597 | 612 | | |
598 | | - | |
| 613 | + | |
599 | 614 | | |
600 | 615 | | |
601 | | - | |
602 | | - | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
603 | 629 | | |
604 | 630 | | |
605 | 631 | | |
| |||
610 | 636 | | |
611 | 637 | | |
612 | 638 | | |
613 | | - | |
| 639 | + | |
614 | 640 | | |
615 | | - | |
| 641 | + | |
616 | 642 | | |
617 | 643 | | |
618 | 644 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
595 | 595 | | |
596 | 596 | | |
597 | 597 | | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
0 commit comments