Repository navigation
Commit 0828f1b
committed
fix(parquet): split RowGroupPruner errors into creation vs evaluation
Per Copilot review on #22450: `RowGroupPruner` was using a single
`predicate_creation_errors` counter for both predicate construction
(`build_pruning_predicate`) AND predicate evaluation
(`PruningPredicate::prune`) failures. The log message also said
"Ignoring error building..." when the failure was during evaluation.
This misattributed evaluation failures and made the metric semantics
inconsistent with the static row-group pruning path in
`RowGroupAccessPlanFilter::prune_by_statistics`, which already
separates the two.
`RowGroupPruner::new` now takes both counters:
- `predicate_creation_errors`: bumped on `build_pruning_predicate`
failures. Wired to `prepared.predicate_creation_errors` from the
opener — same field the static path uses.
- `predicate_evaluation_errors`: bumped on `PruningPredicate::prune`
failures. Wired to `prepared.file_metrics.predicate_evaluation_errors`
— same field the static `prune_by_statistics` path uses, so the two
paths accumulate into a shared counter.
The error log message is updated to say "evaluating" so the metric and
the log agree.1 parent f3adbeb commit 0828f1b
2 files changed
Lines changed: 32 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1266 | 1266 | | |
1267 | 1267 | | |
1268 | 1268 | | |
| 1269 | + | |
1269 | 1270 | | |
1270 | 1271 | | |
1271 | 1272 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
136 | | - | |
| 136 | + | |
137 | 137 | | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
138 | 141 | | |
139 | 142 | | |
140 | 143 | | |
| |||
143 | 146 | | |
144 | 147 | | |
145 | 148 | | |
| 149 | + | |
146 | 150 | | |
147 | 151 | | |
148 | 152 | | |
| |||
151 | 155 | | |
152 | 156 | | |
153 | 157 | | |
| 158 | + | |
154 | 159 | | |
155 | 160 | | |
156 | 161 | | |
| |||
203 | 208 | | |
204 | 209 | | |
205 | 210 | | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
206 | 215 | | |
207 | | - | |
| 216 | + | |
208 | 217 | | |
209 | | - | |
| 218 | + | |
210 | 219 | | |
211 | 220 | | |
212 | 221 | | |
| |||
428 | 437 | | |
429 | 438 | | |
430 | 439 | | |
431 | | - | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
432 | 445 | | |
433 | | - | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
434 | 451 | | |
435 | 452 | | |
436 | 453 | | |
| |||
445 | 462 | | |
446 | 463 | | |
447 | 464 | | |
| 465 | + | |
448 | 466 | | |
449 | 467 | | |
450 | 468 | | |
451 | 469 | | |
452 | | - | |
| 470 | + | |
| 471 | + | |
453 | 472 | | |
454 | 473 | | |
455 | 474 | | |
| |||
474 | 493 | | |
475 | 494 | | |
476 | 495 | | |
| 496 | + | |
477 | 497 | | |
478 | 498 | | |
479 | 499 | | |
480 | 500 | | |
481 | | - | |
| 501 | + | |
| 502 | + | |
482 | 503 | | |
483 | 504 | | |
484 | 505 | | |
| |||
517 | 538 | | |
518 | 539 | | |
519 | 540 | | |
| 541 | + | |
520 | 542 | | |
521 | 543 | | |
522 | 544 | | |
523 | 545 | | |
524 | | - | |
| 546 | + | |
| 547 | + | |
525 | 548 | | |
526 | 549 | | |
527 | 550 | | |
| |||
0 commit comments