Skip to content

chore: Enable GitHub Issues#519

Merged
tisonkun merged 1 commit intomasterfrom
tisonkun-patch-1
Jan 8, 2025
Merged

chore: Enable GitHub Issues#519
tisonkun merged 1 commit intomasterfrom
tisonkun-patch-1

Conversation

@tisonkun
Copy link
Copy Markdown
Member

@tisonkun tisonkun commented Jan 4, 2025 •
edited
Loading

Here we have several open issues:

  1. @gmcdonald, will this move stop all the possibility that INFRA will help migrate JIRA tickets? I remember that I was told not to enable GitHub Issues by myself but to wait for INFRA's response. But as you can see, the ticket gets stalled, and we don't know whether it will make progress.

  2. The PR title and commit message flavor may change. As we now follow CURATOR-xxx where xxx is mapped to a JIRA ticket and we have the autolink to JIRA. With GitHub issues, it can be easily linked within the PR description. And thus,

    1. I'd keep the autolink_jira option for all existing PRs and commits;
    2. I'd suggest all the following PR/commit use Conventional Commits

  3. The release note generation step in release process should be updated. I suppose either GitHub releases can autogenerate one, or we maintain a CHANGELOG file and update it per PR. Either should work.

@tisonkun tisonkun requested review from eolivelli and kezhuw January 4, 2025 09:07
kezhuw
kezhuw approved these changes Jan 7, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kezhuw kezhuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go from my side.

We can do the migration in next step. I am good for jira and github issues to coexist for a while.

@tisonkun tisonkun marked this pull request as ready for review January 8, 2025 04:13
@tisonkun
Copy link
Copy Markdown
Member Author

tisonkun commented Jan 8, 2025

OK. I'll merge this PR in these days.

Let's keep the JIRA project for a while, recommend/ensure users to report new issues on GitHub. Manually migrate existing tickets to GitHub Issues, and finally archive/readonly the JIRA project.

@tisonkun
Copy link
Copy Markdown
Member Author

tisonkun commented Jan 8, 2025

According to the conversation with the INFRA team on Slack:

[@tisonkun] If we can turn on GitHub Issues, we can encourage/ensure new issues goes to GitHub Issues, and softly depreacted the JIRA project. But IIRC I was told not to do so because the INFRA team may finish it at once. So I don't know if, by my turning on the GitHub Issues, I'd unexpectedly break some assumption by the INFRA team.

[INFRA member] I dont think it will break anything as such. PRs and Issues both get their numbering scheme from the same pool. You have over 500 PRs already so when importing issues, CURATOR-1 will start at the first available number - currrently #520. etc etc. The import process has a mapping system whereas it will link the Issue imported back to the original Jira ticket. If desired a final comment is also added to each Jira ticket pointing to the migrated Github Issue.

So I'd merge this PR now and let's move forward.

@tisonkun tisonkun merged commit bdf2402 into master Jan 8, 2025
@tisonkun tisonkun deleted the tisonkun-patch-1 branch January 8, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kezhuw kezhuw kezhuw approved these changes

@eolivelli eolivelli Awaiting requested review from eolivelli

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tisonkun @kezhuw