Skip to content

[CURATOR-721] Upgrade Guava Listenablefuture#509

Merged
kezhuw merged 1 commit intoapache:masterfrom
froque:CURATOR-721-duplicate-ListenableFuture-classpath
Jan 10, 2025
Merged

[CURATOR-721] Upgrade Guava Listenablefuture#509
kezhuw merged 1 commit intoapache:masterfrom
froque:CURATOR-721-duplicate-ListenableFuture-classpath

Conversation

@froque
Copy link
Copy Markdown
Contributor

@froque froque commented Nov 5, 2024

This removes duplicate class ListenableFuture.
See more at google/guava#7385

This removes duplicate class ListenableFuture.
See more at google/guava#7385
@eolivelli
Copy link
Copy Markdown
Contributor

Reopening and closing in order to see if CI kicks in

@eolivelli eolivelli closed this Dec 12, 2024
@eolivelli eolivelli reopened this Dec 12, 2024
@tisonkun tisonkun requested review from eolivelli and kezhuw December 21, 2024 07:19
Copy link
Copy Markdown
Member

@kezhuw kezhuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think we could even drop directy dependencies to com.google.guava:listenablefuture. But it could be a leftover as we probably have more to clean.

@kezhuw kezhuw merged commit 8bbcdbf into apache:master Jan 10, 2025
@froque froque deleted the CURATOR-721-duplicate-ListenableFuture-classpath branch January 10, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants