[CURATOR-653] Proposed changes based on PR #398 #436
Conversation
Signed-off-by: tison <[email protected]>
… class declaration
hm, looks like CI ran into a timeout exceeding the maximum threshold for a CI run of 120min due to |
|
The timeout of {{TestPathChildrenCache}} in the Java 11 CI job seems to be unrelated to this PR's change: It doesn't utilize |
Signed-off-by: tison <[email protected]>
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
LGTM.
@eolivelli you may take a looks at this patch which I think is identical to #398.
We may not always wait for new patches so it's on you when to cut the release. I'll regard this patch and #435 are both not blockers.
|
Merging... |
2 participants
This closes #398.
This PR is based on PR #398 and adds a few comments from my review of that PR
This PR addresses the review comments individually in separate commits to make it easier to select the ones that are relevant. The final commit is a proposal where I refactor using plain Strings in the eventQueue but rather proper objects that enables us to monitor the latch that triggered the event.