Fix PersistentWatcher not working with NamespaceFacade#1262
Merged
kezhuw merged 1 commit intoapache:masterfrom Apr 12, 2025
Merged
Fix PersistentWatcher not working with NamespaceFacade#1262kezhuw merged 1 commit intoapache:masterfrom
kezhuw merged 1 commit intoapache:masterfrom
Conversation
`NamespaceFacade` does not support `getCuratorListenable` while apache#520 use it to listen for `CuratorEventType.CLOSING` to fix CURATOR-729. This commit exports `CuratorFrameworkBase::client` to retrieve underlying framework client to listen for for `CuratorEventType.CLOSING`. Fixes apache#1259.
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
curator-recipes/src/main/java/org/apache/curator/framework/recipes/watch/PersistentWatcher.java:85
- Directly casting the client to CuratorFrameworkBase could lead to a ClassCastException if the client is not an instance of CuratorFrameworkBase. Consider adding an instance check or clarifying that the client must be of that type.
((CuratorFrameworkBase) client).client().getCuratorListenable().addListener(((ignored, event) -> {
Member
Author
|
I think we probably could introduce |
tisonkun
approved these changes
Apr 12, 2025
Member
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
Thanks for taking care of this! LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NamespaceFacadedoes not supportgetCuratorListenablewhile #520 use it to listen forCuratorEventType.CLOSINGto fix CURATOR-729.This commit exports
CuratorFrameworkBase::clientto retrieve underlying framework client to listen for forCuratorEventType.CLOSING.Fixes #1259.