@kotman12 This should close #1256?

@kotman12 This should close #1256?

@tisonkun I hope so, yes!

@kezhuw thanks! A few observations here:

CachedModeledFramework::list indeed ignores data hierarchy and returns all descendants of the base path but this is consistent with the API doc (as well as previous behavior):

Return the instances of the base path of this cached framework

Is your suggestion to add the word "recursively" to the doc somewhere in ModeledCache::currentChildren and CachedModeledFramework::list to stress that it recursively returns children's children? My immediate word of choice is "descendant" but I don't see it used anywhere in the curator docs so I don't want to introduce new terminology.

Tangentially, something I found strange is that CachedModeledFramework::parent is unimplemented but you can still potentially get the parent's modeled data if it is under the cache's base path.

@kotman12 Merged. Thank you for your contribution!

but this is consistent with the API doc

Yeh, I saw.

Regarding ModeledCache::currentChildren, I think it is normal that "children" is not recursive just like ZooKeeper::getChildren. Given that it is a public api, I think there is no much room for us to change except documentation.